You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/11/19 12:43:46 UTC
[GitHub] [rocketmq] hzh0425 opened a new pull request, #5546: [Issue #4330]Fix some comments in DefaultElectPolicy
hzh0425 opened a new pull request, #5546:
URL: https://github.com/apache/rocketmq/pull/5546
**Make sure set the target branch to `develop`**
## What is the purpose of the change
Fix some comments in DefaultElectPolicy
## Brief changelog
Fix some comments in DefaultElectPolicy
## Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-commenter commented on pull request #5546: [Issue #4330]Fix some comments in DefaultElectPolicy
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #5546:
URL: https://github.com/apache/rocketmq/pull/5546#issuecomment-1320882728
# [Codecov](https://codecov.io/gh/apache/rocketmq/pull/5546?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#5546](https://codecov.io/gh/apache/rocketmq/pull/5546?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bc9055d) into [develop](https://codecov.io/gh/apache/rocketmq/commit/a7c1d49454ce405fc651f95d036571d91bd8c9e0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a7c1d49) will **decrease** coverage by `0.38%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## develop #5546 +/- ##
=============================================
- Coverage 43.18% 42.79% -0.39%
- Complexity 8009 8040 +31
=============================================
Files 1016 1031 +15
Lines 71535 72741 +1206
Branches 9467 9613 +146
=============================================
+ Hits 30891 31132 +241
- Misses 36751 37668 +917
- Partials 3893 3941 +48
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/5546?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...etmq/controller/elect/impl/DefaultElectPolicy.java](https://codecov.io/gh/apache/rocketmq/pull/5546/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvY29udHJvbGxlci9lbGVjdC9pbXBsL0RlZmF1bHRFbGVjdFBvbGljeS5qYXZh) | `75.00% <100.00%> (ø)` | |
| [...che/rocketmq/common/consumer/ConsumeFromWhere.java](https://codecov.io/gh/apache/rocketmq/pull/5546/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vY29uc3VtZXIvQ29uc3VtZUZyb21XaGVyZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...g/apache/rocketmq/common/utils/CheckpointFile.java](https://codecov.io/gh/apache/rocketmq/pull/5546/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vdXRpbHMvQ2hlY2twb2ludEZpbGUuamF2YQ==) | `0.00% <0.00%> (-74.55%)` | :arrow_down: |
| [...apache/rocketmq/remoting/common/ServiceThread.java](https://codecov.io/gh/apache/rocketmq/pull/5546/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL2NvbW1vbi9TZXJ2aWNlVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-73.34%)` | :arrow_down: |
| [...g/apache/rocketmq/common/message/MessageQueue.java](https://codecov.io/gh/apache/rocketmq/pull/5546/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vbWVzc2FnZS9NZXNzYWdlUXVldWUuamF2YQ==) | `0.00% <0.00%> (-45.46%)` | :arrow_down: |
| [...he/rocketmq/broker/mqtrace/SendMessageContext.java](https://codecov.io/gh/apache/rocketmq/pull/5546/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvbXF0cmFjZS9TZW5kTWVzc2FnZUNvbnRleHQuamF2YQ==) | `34.34% <0.00%> (-28.29%)` | :arrow_down: |
| [.../apache/rocketmq/common/filter/ExpressionType.java](https://codecov.io/gh/apache/rocketmq/pull/5546/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vZmlsdGVyL0V4cHJlc3Npb25UeXBlLmphdmE=) | `0.00% <0.00%> (-25.00%)` | :arrow_down: |
| [...n/java/org/apache/rocketmq/common/TopicConfig.java](https://codecov.io/gh/apache/rocketmq/pull/5546/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vVG9waWNDb25maWcuamF2YQ==) | `36.84% <0.00%> (-19.55%)` | :arrow_down: |
| [...he/rocketmq/common/attribute/TopicMessageType.java](https://codecov.io/gh/apache/rocketmq/pull/5546/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vYXR0cmlidXRlL1RvcGljTWVzc2FnZVR5cGUuamF2YQ==) | `91.66% <0.00%> (-8.34%)` | :arrow_down: |
| [...ocketmq/broker/processor/SendMessageProcessor.java](https://codecov.io/gh/apache/rocketmq/pull/5546/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcHJvY2Vzc29yL1NlbmRNZXNzYWdlUHJvY2Vzc29yLmphdmE=) | `37.74% <0.00%> (-6.42%)` | :arrow_down: |
| ... and [592 more](https://codecov.io/gh/apache/rocketmq/pull/5546/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin merged pull request #5546: [Issue #4330]Fix some comments in DefaultElectPolicy
Posted by GitBox <gi...@apache.org>.
RongtongJin merged PR #5546:
URL: https://github.com/apache/rocketmq/pull/5546
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org