You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/01/31 09:11:09 UTC
[GitHub] [skywalking] mrproliu opened a new pull request #4303: provide
profile analyze empty interfaces
mrproliu opened a new pull request #4303: provide profile analyze empty interfaces
URL: https://github.com/apache/skywalking/pull/4303
Please answer these questions before submitting pull request
- Why submit this pull request?
- [ ] Bug fix
- [x] New feature provided
- [ ] Improve performance
- Related issues
#4104
https://github.com/apache/skywalking-query-protocol/pull/29
___
### New feature or improvement
- provide profile GraphQL interfaces, make compiling and boot successfully.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4303:
provide profile analyze empty interfaces
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4303: provide profile analyze empty interfaces
URL: https://github.com/apache/skywalking/pull/4303#discussion_r373384431
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/query/entity/ProfileStackElement.java
##########
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.query.entity;
+
+import lombok.Getter;
+import lombok.Setter;
+
+import java.util.List;
+
+/**
+ * @author MrPro
+ */
+@Getter
+@Setter
+public class ProfileStackElement {
+
+ // stack code signature
+ private String codeSignature;
+
+ // self include children duration(millisecond)
Review comment:
Wrong comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng merged pull request #4303: provide profile
analyze empty interfaces
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #4303: provide profile analyze empty interfaces
URL: https://github.com/apache/skywalking/pull/4303
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4303: provide
profile analyze empty interfaces
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4303: provide profile analyze empty interfaces
URL: https://github.com/apache/skywalking/pull/4303#issuecomment-580705725
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4303?src=pr&el=h1) Report
> Merging [#4303](https://codecov.io/gh/apache/skywalking/pull/4303?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9a433e5bc4da9a7a2a360bbc24504b3bf91e102b?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4303?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4303 +/- ##
=======================================
Coverage 26.81% 26.81%
=======================================
Files 1168 1168
Lines 25528 25528
Branches 3638 3638
=======================================
Hits 6845 6845
Misses 18077 18077
Partials 606 606
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4303?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4303?src=pr&el=footer). Last update [9a433e5...93ab2ac](https://codecov.io/gh/apache/skywalking/pull/4303?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4303: provide
profile analyze empty interfaces
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4303: provide profile analyze empty interfaces
URL: https://github.com/apache/skywalking/pull/4303#issuecomment-580705725
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4303?src=pr&el=h1) Report
> Merging [#4303](https://codecov.io/gh/apache/skywalking/pull/4303?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9a433e5bc4da9a7a2a360bbc24504b3bf91e102b?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4303?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4303 +/- ##
=======================================
Coverage 26.81% 26.81%
=======================================
Files 1168 1168
Lines 25528 25528
Branches 3638 3638
=======================================
Hits 6845 6845
Misses 18077 18077
Partials 606 606
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4303?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4303?src=pr&el=footer). Last update [9a433e5...93ab2ac](https://codecov.io/gh/apache/skywalking/pull/4303?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4303:
provide profile analyze empty interfaces
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4303: provide profile analyze empty interfaces
URL: https://github.com/apache/skywalking/pull/4303#discussion_r373384409
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/query/entity/ProfileStackElement.java
##########
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.query.entity;
+
+import lombok.Getter;
+import lombok.Setter;
+
+import java.util.List;
+
+/**
+ * @author MrPro
+ */
+@Getter
+@Setter
+public class ProfileStackElement {
+
+ // stack code signature
+ private String codeSignature;
+
+ // self include children duration(millisecond)
+ private int duration;
+
+ // self exclude children duration(millisecond)
Review comment:
Wrong comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io commented on issue #4303: provide profile
analyze empty interfaces
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4303: provide profile analyze empty interfaces
URL: https://github.com/apache/skywalking/pull/4303#issuecomment-580705725
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4303?src=pr&el=h1) Report
> Merging [#4303](https://codecov.io/gh/apache/skywalking/pull/4303?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9a433e5bc4da9a7a2a360bbc24504b3bf91e102b?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4303?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4303 +/- ##
=======================================
Coverage 26.81% 26.81%
=======================================
Files 1168 1168
Lines 25528 25528
Branches 3638 3638
=======================================
Hits 6845 6845
Misses 18077 18077
Partials 606 606
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4303?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4303?src=pr&el=footer). Last update [9a433e5...93ab2ac](https://codecov.io/gh/apache/skywalking/pull/4303?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services