[jira] [Commented] (ARIES-1710) Configurable enable-annotation element in blueprint xml

["Dominik Przybysz (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARIES-1710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15955616#comment-15955616 ] 

Dominik Przybysz commented on ARIES-1710:
-----------------------------------------

[~chris@die-schneider.net] I propose some changes for provided patch:

1) Rename custom property to "transaction.enableAnnotation"
2) Do not apply such property for namespace in version 2.0.0
3) Simplify getEnableAnnotationConfig condition to 

{code}
    private boolean getEnableAnnotationConfig(BlueprintConfiguration blueprintConfig) {
        String enableAnnotation = blueprintConfig.getCustomParameters().get(ENABLE_ANNOTATION);
        return enableAnnotation == null || Boolean.parseBoolean(enableAnnotation);
    }
{code}

4) Add at least one integration test checking if custom parameter is successfully passed to handlers.
5) Speed up tests by adding Singleton annotaion on MyBean8 and move it to another package. EnableAnnotationTest should parse only this package so it should be quicker.

> Configurable enable-annotation element in blueprint xml
> -------------------------------------------------------
>
>                 Key: ARIES-1710
>                 URL: https://issues.apache.org/jira/browse/ARIES-1710
>             Project: Aries
>          Issue Type: Improvement
>          Components: Blueprint
>    Affects Versions: blueprint-maven-plugin-1.6.0
>            Reporter: Andrei Shakirin
>            Assignee: Christian Schneider
>         Attachments: blueprint-maven-plugin.patch
>
>
> Currently tx:enable-annotation element is always added for 1.0.0, 1.1.0, 1.2.0 and 2.0.0 transaction namespaces by blueprint-plugin.
> This element enables scanning of @Transactional attribute in beans additionally to blueprint configuration
> Problems:
> 1) 1.0.0 and 1.1.0 schemas doesn't support this element at all
> 2) for 1.2.0 there are use cases to skip annotation scanning and use only configured transaction attributes in xml
> Proposal:
> 1) enable element only for 1.2.0 and 2.0.0 namespaces
> 2) provide configuration property to deactivate injection of this element



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)