[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #6858: allow a new upgrade version without DB changes to be inserted

[GitBox <gi...@apache.org>]

rohityadavcloud commented on code in PR #6858:
URL: https://github.com/apache/cloudstack/pull/6858#discussion_r1011260901


##########
engine/schema/src/main/java/com/cloud/upgrade/DatabaseVersionHierarchy.java:
##########
@@ -131,7 +131,7 @@ private CloudStackVersion getRecentVersion(final CloudStackVersion fromVersion)
         return toList()
                  .reverse()
                  .stream()
-                 .filter(version -> fromVersion.compareTo(version) < 0)

Review Comment:
   Should we just remove the last digit (from a.b.c.d; remove .d) in the upgrade paths map and the logic that obtains current ACS version (to report a.b.c only to DB upgrade path processors?)



##########
engine/schema/pom.xml:
##########
@@ -57,6 +57,18 @@
             <artifactId>ini4j</artifactId>
             <version>${cs.ini.version}</version>
         </dependency>
+        <dependency>
+            <groupId>org.junit.jupiter</groupId>
+            <artifactId>junit-jupiter</artifactId>
+            <version>RELEASE</version>

Review Comment:
   should we specify some version here? @DaanHoogland 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org