You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/04/14 05:33:20 UTC
[GitHub] [iceberg] aokolnychyi opened a new pull request #2473: Spark: Add new entry point for actions
aokolnychyi opened a new pull request #2473:
URL: https://github.com/apache/iceberg/pull/2473
This PR adds new entry points for the redesigned actions API in Spark.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on pull request #2473: Spark: Add new entry point for actions
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on pull request #2473:
URL: https://github.com/apache/iceberg/pull/2473#issuecomment-819240491
@rdblue @RussellSpitzer @openinx, could you take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on pull request #2473: Spark: Add new entry point for actions
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on pull request #2473:
URL: https://github.com/apache/iceberg/pull/2473#issuecomment-819240918
The idea is to offer new entry points like this:
```
org.apache.iceberg.spark.actions.SparkActions
org.apache.iceberg.flink.actions.FlinkActions
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on a change in pull request #2473: Spark: Add new entry point for actions
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on a change in pull request #2473:
URL: https://github.com/apache/iceberg/pull/2473#discussion_r612949018
##########
File path: spark/src/main/java/org/apache/iceberg/spark/actions/BaseSparkActions.java
##########
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iceberg.spark.actions;
+
+import org.apache.iceberg.Table;
+import org.apache.iceberg.actions.ActionsProvider;
+import org.apache.iceberg.actions.ExpireSnapshots;
+import org.apache.iceberg.actions.RemoveOrphanFiles;
+import org.apache.iceberg.actions.RewriteManifests;
+import org.apache.spark.sql.SparkSession;
+
+abstract class BaseSparkActions implements ActionsProvider {
Review comment:
We don't have data compaction yet. That's why I did not deprecate the old entry points yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on a change in pull request #2473: Spark: Add new entry point for actions
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on a change in pull request #2473:
URL: https://github.com/apache/iceberg/pull/2473#discussion_r612949400
##########
File path: spark2/src/main/java/org/apache/iceberg/spark/actions/SparkActions.java
##########
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iceberg.spark.actions;
+
+import org.apache.iceberg.actions.ActionsProvider;
+import org.apache.spark.sql.SparkSession;
+
+/**
+ * An implementation of {@link ActionsProvider} for Spark.
+ * <p>
+ * This class is the primary API for interacting with actions in Spark that users should use
+ * to instantiate particular actions.
+ */
+public class SparkActions extends BaseSparkActions {
Review comment:
No more reflection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #2473: Spark: Add new entry point for actions
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #2473:
URL: https://github.com/apache/iceberg/pull/2473
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org