[GitHub] [pulsar] rdhabalia commented on a change in pull request #4400: PIP 37: [pulsar-client] support large message size

[GitBox <gi...@apache.org>]

rdhabalia commented on a change in pull request #4400:
URL: https://github.com/apache/pulsar/pull/4400#discussion_r433473276



##########
File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerBuilderImpl.java
##########
@@ -96,6 +96,9 @@ private ProducerBuilderImpl(PulsarClientImpl client, ProducerConfigurationData c
 
     @Override
     public CompletableFuture<Producer<T>> createAsync() {
+        // config validation
+        checkArgument(!(conf.isBatchingEnabled() && conf.isChunkingEnabled()),

Review comment:
       @codelipenghui we can do but it will be little tricky to cover all usecases as we use batch-container if batching is enabled and combination of non-batch and batching will be little tricky. I have already put good amount of efforts to rebase and doing perf testing with changes. so, let's merge this PR and I will create a issue to add this feature and address it in separate PR as it will also require some effort to cover all unknowns.
   So, can you please review this PR again as I am done with rebasing.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org