You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by bostko <gi...@git.apache.org> on 2017/03/21 19:12:43 UTC
[GitHub] brooklyn-server pull request #603: WinRmMachineLocation obtaining WinRmTool ...
GitHub user bostko opened a pull request:
https://github.com/apache/brooklyn-server/pull/603
WinRmMachineLocation obtaining WinRmTool parameters via its config().get
- This allows WinrmTool props to be supplied via external configuration providers.
- WinRmTool instantiation is made to be the same as in SshMachineLocation#connectSsh
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bostko/brooklyn-server winrm-machinelocation-shelltool-props
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/603.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #603
----
commit cb166d51b7fc2e09ab098d9e27cbceb4549a0724
Author: Valentin Aitken <bo...@gmail.com>
Date: 2017-03-21T19:03:24Z
WinRmMachineLocation obtaining WinRmTool parameters via its config().get
- This allows WinrmTool props to be supplied via external configuration providers.
- WinRmTool instantiation is made to be the same as in SshMachineLocation
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #603: WinRmMachineLocation obtaining WinRmTool paramet...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/603
This fixes https://issues.apache.org/jira/browse/BROOKLYN-476
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #603: WinRmMachineLocation obtaining WinRmTool paramet...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the issue:
https://github.com/apache/brooklyn-server/pull/603
LGTM. @bostko can you add a test to verify the changes work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #603: WinRmMachineLocation obtaining WinRmTool paramet...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the issue:
https://github.com/apache/brooklyn-server/pull/603
* You'd need your test living in `brooklyn-camp`, see `ExternalConfigBrooklynPropertiesTest` for an example on how to set it up
* Have a look at tests using `RecordingWinRmTool` for examples of a unit-testable winrm location. See `AbstractJcloudsStubYamlTest` for a yaml-accessible location
* `JcloudsExternalConfigYamlTest` might be just what you need as a starting point
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #603: WinRmMachineLocation obtaining WinRmTool paramet...
Posted by bostko <gi...@git.apache.org>.
Github user bostko commented on the issue:
https://github.com/apache/brooklyn-server/pull/603
I missed to add that my concern is that I do not know find suitable place to put such test.
Adding test in brooklyn-camp or brooklyn-software-winrm will introduce circular dependency.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #603: WinRmMachineLocation obtaining WinRmTool paramet...
Posted by bostko <gi...@git.apache.org>.
Github user bostko commented on the issue:
https://github.com/apache/brooklyn-server/pull/603
@neykov as far as I can see test for this requires two things:
- BrooklynCampPlatformLauncherNoServer in order external config to work https://github.com/apache/brooklyn-server/blob/master/camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/BrooklynCampPlatform.java#L90
- WinRmMachineLocation in order to test it
Could you advice on how to approach writing such test?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request #603: WinRmMachineLocation obtaining WinRmTool ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/603
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #603: WinRmMachineLocation obtaining WinRmTool paramet...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the issue:
https://github.com/apache/brooklyn-server/pull/603
Thanks @bostko, merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #603: WinRmMachineLocation obtaining WinRmTool paramet...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the issue:
https://github.com/apache/brooklyn-server/pull/603
`AbstractJcloudsStubYamlTest` in `brooklyn-camp` already depends on `brooklyn-software-winrm`. Adding the test in `brooklyn-camp` would be fine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---