[GitHub] [incubator-openwhisk] style95 commented on a change in pull request #4329: Redirect http to https and other nginx config cleanup.

[GitBox <gi...@apache.org>]

style95 commented on a change in pull request #4329: Redirect http to https and other nginx config cleanup.
URL: https://github.com/apache/incubator-openwhisk/pull/4329#discussion_r264040818
 
 

 ##########
 File path: ansible/roles/nginx/templates/nginx.conf.j2
 ##########
 @@ -89,20 +89,27 @@ http {
 {# Turn off sending information about the server to the client #}
     server_tokens off;
 
+    # Redirect all http to https.
+    server {
+        listen 80 default_server;
+        server_name _;
+        return 301 https://$host$request_uri;
 
 Review comment:
   In some down streams, they might want to use http for some performance reason.
   How about making this redirection configurable?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services