You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by tv...@apache.org on 2014/05/23 12:49:59 UTC
svn commit: r1597056 - in /tomee/tomee/trunk: ./
container/openejb-api/src/main/java/org/apache/openejb/api/
container/openejb-api/src/main/java/org/apache/openejb/api/jmx/
container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/con...
Author: tveronezi
Date: Fri May 23 10:49:58 2014
New Revision: 1597056
URL: http://svn.apache.org/r1597056
Log:
The styles (pmd and checkstyle) will be checked by the 'style' profile.
Applying checkstyle/pmd changes to:
* openejb-api;
* openejb-utilities-ee
* openejb-javaagent
* openejb-jpa-integration.
Adding support to @Supresswarnings("checkstyle:..."). Usage example in ClassPathFactory.java
Modified:
tomee/tomee/trunk/container/openejb-api/src/main/java/org/apache/openejb/api/EjbDeployment.java
tomee/tomee/trunk/container/openejb-api/src/main/java/org/apache/openejb/api/LocalClient.java
tomee/tomee/trunk/container/openejb-api/src/main/java/org/apache/openejb/api/Monitor.java
tomee/tomee/trunk/container/openejb-api/src/main/java/org/apache/openejb/api/Proxy.java
tomee/tomee/trunk/container/openejb-api/src/main/java/org/apache/openejb/api/RemoteClient.java
tomee/tomee/trunk/container/openejb-api/src/main/java/org/apache/openejb/api/jmx/Description.java
tomee/tomee/trunk/container/openejb-api/src/main/java/org/apache/openejb/api/jmx/MBean.java
tomee/tomee/trunk/container/openejb-api/src/main/java/org/apache/openejb/api/jmx/ManagedAttribute.java
tomee/tomee/trunk/container/openejb-api/src/main/java/org/apache/openejb/api/jmx/ManagedOperation.java
tomee/tomee/trunk/container/openejb-api/src/main/java/org/apache/openejb/api/jmx/NotificationInfo.java
tomee/tomee/trunk/container/openejb-api/src/main/java/org/apache/openejb/api/jmx/NotificationInfos.java
tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/factory/ManagedExecutorServiceImplFactory.java
tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/factory/ManagedScheduledExecutorServiceImplFactory.java
tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/factory/ManagedThreadFactoryImplFactory.java
tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/future/CUFuture.java
tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/future/CUScheduleFuture.java
tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/impl/ContextServiceImpl.java
tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/impl/ManagedExecutorServiceImpl.java
tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/impl/ManagedScheduledExecutorServiceImpl.java
tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/impl/ManagedThreadFactoryImpl.java
tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/reject/CURejectHandler.java
tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/task/CUCallable.java
tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/task/CURunnable.java
tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/task/CUTask.java
tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/task/ManagedTaskListenerTask.java
tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/task/TriggerCallable.java
tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/task/TriggerRunnable.java
tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/task/TriggerTask.java
tomee/tomee/trunk/container/openejb-javaagent/src/main/java/org/apache/openejb/javaagent/Agent.java
tomee/tomee/trunk/container/openejb-jpa-integration/src/main/java/org/apache/openejb/jpa/integration/MakeTxLookup.java
tomee/tomee/trunk/container/openejb-jpa-integration/src/main/java/org/apache/openejb/jpa/integration/eclipselink/PrefixSessionCustomizer.java
tomee/tomee/trunk/container/openejb-jpa-integration/src/main/java/org/apache/openejb/jpa/integration/hibernate/PrefixNamingStrategy.java
tomee/tomee/trunk/container/openejb-loader/src/main/java/org/apache/openejb/loader/ClassPathFactory.java
tomee/tomee/trunk/pom.xml
tomee/tomee/trunk/src/main/style/checkstyle.xml
Modified: tomee/tomee/trunk/container/openejb-api/src/main/java/org/apache/openejb/api/EjbDeployment.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-api/src/main/java/org/apache/openejb/api/EjbDeployment.java?rev=1597056&r1=1597055&r2=1597056&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-api/src/main/java/org/apache/openejb/api/EjbDeployment.java (original)
+++ tomee/tomee/trunk/container/openejb-api/src/main/java/org/apache/openejb/api/EjbDeployment.java Fri May 23 10:49:58 2014
@@ -1,4 +1,4 @@
-/**
+/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
@@ -8,11 +8,11 @@
*
* http://www.apache.org/licenses/LICENSE-2.0
*
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
*/
package org.apache.openejb.api;
Modified: tomee/tomee/trunk/container/openejb-api/src/main/java/org/apache/openejb/api/LocalClient.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-api/src/main/java/org/apache/openejb/api/LocalClient.java?rev=1597056&r1=1597055&r2=1597056&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-api/src/main/java/org/apache/openejb/api/LocalClient.java (original)
+++ tomee/tomee/trunk/container/openejb-api/src/main/java/org/apache/openejb/api/LocalClient.java Fri May 23 10:49:58 2014
@@ -1,4 +1,4 @@
-/**
+/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
@@ -8,11 +8,11 @@
*
* http://www.apache.org/licenses/LICENSE-2.0
*
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
*/
package org.apache.openejb.api;
Modified: tomee/tomee/trunk/container/openejb-api/src/main/java/org/apache/openejb/api/Monitor.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-api/src/main/java/org/apache/openejb/api/Monitor.java?rev=1597056&r1=1597055&r2=1597056&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-api/src/main/java/org/apache/openejb/api/Monitor.java (original)
+++ tomee/tomee/trunk/container/openejb-api/src/main/java/org/apache/openejb/api/Monitor.java Fri May 23 10:49:58 2014
@@ -1,4 +1,4 @@
-/**
+/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
@@ -8,11 +8,11 @@
*
* http://www.apache.org/licenses/LICENSE-2.0
*
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
*/
package org.apache.openejb.api;
Modified: tomee/tomee/trunk/container/openejb-api/src/main/java/org/apache/openejb/api/Proxy.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-api/src/main/java/org/apache/openejb/api/Proxy.java?rev=1597056&r1=1597055&r2=1597056&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-api/src/main/java/org/apache/openejb/api/Proxy.java (original)
+++ tomee/tomee/trunk/container/openejb-api/src/main/java/org/apache/openejb/api/Proxy.java Fri May 23 10:49:58 2014
@@ -1,4 +1,4 @@
-/**
+/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
@@ -8,11 +8,11 @@
*
* http://www.apache.org/licenses/LICENSE-2.0
*
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
*/
package org.apache.openejb.api;
Modified: tomee/tomee/trunk/container/openejb-api/src/main/java/org/apache/openejb/api/RemoteClient.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-api/src/main/java/org/apache/openejb/api/RemoteClient.java?rev=1597056&r1=1597055&r2=1597056&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-api/src/main/java/org/apache/openejb/api/RemoteClient.java (original)
+++ tomee/tomee/trunk/container/openejb-api/src/main/java/org/apache/openejb/api/RemoteClient.java Fri May 23 10:49:58 2014
@@ -1,4 +1,4 @@
-/**
+/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
@@ -8,11 +8,11 @@
*
* http://www.apache.org/licenses/LICENSE-2.0
*
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
*/
package org.apache.openejb.api;
Modified: tomee/tomee/trunk/container/openejb-api/src/main/java/org/apache/openejb/api/jmx/Description.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-api/src/main/java/org/apache/openejb/api/jmx/Description.java?rev=1597056&r1=1597055&r2=1597056&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-api/src/main/java/org/apache/openejb/api/jmx/Description.java (original)
+++ tomee/tomee/trunk/container/openejb-api/src/main/java/org/apache/openejb/api/jmx/Description.java Fri May 23 10:49:58 2014
@@ -1,4 +1,4 @@
-/**
+/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
@@ -8,11 +8,11 @@
*
* http://www.apache.org/licenses/LICENSE-2.0
*
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
*/
package org.apache.openejb.api.jmx;
@@ -25,14 +25,14 @@ import java.lang.annotation.Target;
@Documented
@Retention(value=RetentionPolicy.RUNTIME)
@Target(value={
- ElementType.CONSTRUCTOR,
- ElementType.FIELD,
- ElementType.METHOD,
- ElementType.PARAMETER,
- ElementType.TYPE
+ ElementType.CONSTRUCTOR,
+ ElementType.FIELD,
+ ElementType.METHOD,
+ ElementType.PARAMETER,
+ ElementType.TYPE
})
public @interface Description {
- String value() default "";
- String bundleBaseName() default "";
- String key() default "";
+ String value() default "";
+ String bundleBaseName() default "";
+ String key() default "";
}
Modified: tomee/tomee/trunk/container/openejb-api/src/main/java/org/apache/openejb/api/jmx/MBean.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-api/src/main/java/org/apache/openejb/api/jmx/MBean.java?rev=1597056&r1=1597055&r2=1597056&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-api/src/main/java/org/apache/openejb/api/jmx/MBean.java (original)
+++ tomee/tomee/trunk/container/openejb-api/src/main/java/org/apache/openejb/api/jmx/MBean.java Fri May 23 10:49:58 2014
@@ -1,4 +1,4 @@
-/**
+/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
@@ -8,11 +8,11 @@
*
* http://www.apache.org/licenses/LICENSE-2.0
*
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
*/
package org.apache.openejb.api.jmx;
Modified: tomee/tomee/trunk/container/openejb-api/src/main/java/org/apache/openejb/api/jmx/ManagedAttribute.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-api/src/main/java/org/apache/openejb/api/jmx/ManagedAttribute.java?rev=1597056&r1=1597055&r2=1597056&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-api/src/main/java/org/apache/openejb/api/jmx/ManagedAttribute.java (original)
+++ tomee/tomee/trunk/container/openejb-api/src/main/java/org/apache/openejb/api/jmx/ManagedAttribute.java Fri May 23 10:49:58 2014
@@ -1,4 +1,4 @@
-/**
+/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
@@ -8,11 +8,11 @@
*
* http://www.apache.org/licenses/LICENSE-2.0
*
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
*/
package org.apache.openejb.api.jmx;
Modified: tomee/tomee/trunk/container/openejb-api/src/main/java/org/apache/openejb/api/jmx/ManagedOperation.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-api/src/main/java/org/apache/openejb/api/jmx/ManagedOperation.java?rev=1597056&r1=1597055&r2=1597056&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-api/src/main/java/org/apache/openejb/api/jmx/ManagedOperation.java (original)
+++ tomee/tomee/trunk/container/openejb-api/src/main/java/org/apache/openejb/api/jmx/ManagedOperation.java Fri May 23 10:49:58 2014
@@ -1,4 +1,4 @@
-/**
+/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
@@ -8,11 +8,11 @@
*
* http://www.apache.org/licenses/LICENSE-2.0
*
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
*/
package org.apache.openejb.api.jmx;
Modified: tomee/tomee/trunk/container/openejb-api/src/main/java/org/apache/openejb/api/jmx/NotificationInfo.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-api/src/main/java/org/apache/openejb/api/jmx/NotificationInfo.java?rev=1597056&r1=1597055&r2=1597056&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-api/src/main/java/org/apache/openejb/api/jmx/NotificationInfo.java (original)
+++ tomee/tomee/trunk/container/openejb-api/src/main/java/org/apache/openejb/api/jmx/NotificationInfo.java Fri May 23 10:49:58 2014
@@ -1,4 +1,4 @@
-/**
+/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
@@ -8,11 +8,11 @@
*
* http://www.apache.org/licenses/LICENSE-2.0
*
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
*/
package org.apache.openejb.api.jmx;
@@ -29,8 +29,8 @@ import java.lang.annotation.Target;
@Target(value = ElementType.TYPE)
@Retention(value = RetentionPolicy.RUNTIME)
public @interface NotificationInfo {
- String[] types() default {};
- Description description() default @Description(value = "");
- Class<? extends Notification> notificationClass() default Notification.class;
- String[] descriptorFields() default {};
+ String[] types() default {};
+ Description description() default @Description(value = "");
+ Class<? extends Notification> notificationClass() default Notification.class;
+ String[] descriptorFields() default {};
}
Modified: tomee/tomee/trunk/container/openejb-api/src/main/java/org/apache/openejb/api/jmx/NotificationInfos.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-api/src/main/java/org/apache/openejb/api/jmx/NotificationInfos.java?rev=1597056&r1=1597055&r2=1597056&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-api/src/main/java/org/apache/openejb/api/jmx/NotificationInfos.java (original)
+++ tomee/tomee/trunk/container/openejb-api/src/main/java/org/apache/openejb/api/jmx/NotificationInfos.java Fri May 23 10:49:58 2014
@@ -1,4 +1,4 @@
-/**
+/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
@@ -8,11 +8,11 @@
*
* http://www.apache.org/licenses/LICENSE-2.0
*
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
*/
package org.apache.openejb.api.jmx;
@@ -28,5 +28,5 @@ import java.lang.annotation.Target;
@Target(value = ElementType.TYPE)
@Retention(value = RetentionPolicy.RUNTIME)
public @interface NotificationInfos {
- NotificationInfo[] value();
+ NotificationInfo[] value();
}
Modified: tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/factory/ManagedExecutorServiceImplFactory.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/factory/ManagedExecutorServiceImplFactory.java?rev=1597056&r1=1597055&r2=1597056&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/factory/ManagedExecutorServiceImplFactory.java (original)
+++ tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/factory/ManagedExecutorServiceImplFactory.java Fri May 23 10:49:58 2014
@@ -1,4 +1,4 @@
-/**
+/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
Modified: tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/factory/ManagedScheduledExecutorServiceImplFactory.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/factory/ManagedScheduledExecutorServiceImplFactory.java?rev=1597056&r1=1597055&r2=1597056&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/factory/ManagedScheduledExecutorServiceImplFactory.java (original)
+++ tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/factory/ManagedScheduledExecutorServiceImplFactory.java Fri May 23 10:49:58 2014
@@ -1,4 +1,4 @@
-/**
+/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
Modified: tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/factory/ManagedThreadFactoryImplFactory.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/factory/ManagedThreadFactoryImplFactory.java?rev=1597056&r1=1597055&r2=1597056&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/factory/ManagedThreadFactoryImplFactory.java (original)
+++ tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/factory/ManagedThreadFactoryImplFactory.java Fri May 23 10:49:58 2014
@@ -14,6 +14,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
+
package org.apache.openejb.concurrencyutilities.ee.factory;
import org.apache.openejb.concurrencyutilities.ee.impl.ManagedThreadFactoryImpl;
Modified: tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/future/CUFuture.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/future/CUFuture.java?rev=1597056&r1=1597055&r2=1597056&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/future/CUFuture.java (original)
+++ tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/future/CUFuture.java Fri May 23 10:49:58 2014
@@ -1,4 +1,4 @@
-/**
+/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
Modified: tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/future/CUScheduleFuture.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/future/CUScheduleFuture.java?rev=1597056&r1=1597055&r2=1597056&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/future/CUScheduleFuture.java (original)
+++ tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/future/CUScheduleFuture.java Fri May 23 10:49:58 2014
@@ -1,4 +1,4 @@
-/**
+/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
Modified: tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/impl/ContextServiceImpl.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/impl/ContextServiceImpl.java?rev=1597056&r1=1597055&r2=1597056&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/impl/ContextServiceImpl.java (original)
+++ tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/impl/ContextServiceImpl.java Fri May 23 10:49:58 2014
@@ -1,4 +1,4 @@
-/**
+/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
Modified: tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/impl/ManagedExecutorServiceImpl.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/impl/ManagedExecutorServiceImpl.java?rev=1597056&r1=1597055&r2=1597056&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/impl/ManagedExecutorServiceImpl.java (original)
+++ tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/impl/ManagedExecutorServiceImpl.java Fri May 23 10:49:58 2014
@@ -1,4 +1,4 @@
-/**
+/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
@@ -33,7 +33,7 @@ public class ManagedExecutorServiceImpl
private final ExecutorService delegate;
private final Duration waitAtShutdown;
- public ManagedExecutorServiceImpl(final ExecutorService delegate, Duration waitAtShutdown) {
+ public ManagedExecutorServiceImpl(final ExecutorService delegate, final Duration waitAtShutdown) {
this.delegate = delegate;
this.waitAtShutdown = waitAtShutdown;
}
Modified: tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/impl/ManagedScheduledExecutorServiceImpl.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/impl/ManagedScheduledExecutorServiceImpl.java?rev=1597056&r1=1597055&r2=1597056&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/impl/ManagedScheduledExecutorServiceImpl.java (original)
+++ tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/impl/ManagedScheduledExecutorServiceImpl.java Fri May 23 10:49:58 2014
@@ -1,4 +1,4 @@
-/**
+/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
Modified: tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/impl/ManagedThreadFactoryImpl.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/impl/ManagedThreadFactoryImpl.java?rev=1597056&r1=1597055&r2=1597056&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/impl/ManagedThreadFactoryImpl.java (original)
+++ tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/impl/ManagedThreadFactoryImpl.java Fri May 23 10:49:58 2014
@@ -1,4 +1,4 @@
-/**
+/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
@@ -34,7 +34,7 @@ public class ManagedThreadFactoryImpl im
}
@Override
- public Thread newThread(Runnable r) {
+ public Thread newThread(final Runnable r) {
final Thread thread = new ManagedThread(r);
thread.setDaemon(true);
thread.setName(prefix + ID.incrementAndGet());
Modified: tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/reject/CURejectHandler.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/reject/CURejectHandler.java?rev=1597056&r1=1597055&r2=1597056&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/reject/CURejectHandler.java (original)
+++ tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/reject/CURejectHandler.java Fri May 23 10:49:58 2014
@@ -1,4 +1,4 @@
-/**
+/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
Modified: tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/task/CUCallable.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/task/CUCallable.java?rev=1597056&r1=1597055&r2=1597056&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/task/CUCallable.java (original)
+++ tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/task/CUCallable.java Fri May 23 10:49:58 2014
@@ -1,4 +1,4 @@
-/**
+/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
Modified: tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/task/CURunnable.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/task/CURunnable.java?rev=1597056&r1=1597055&r2=1597056&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/task/CURunnable.java (original)
+++ tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/task/CURunnable.java Fri May 23 10:49:58 2014
@@ -1,4 +1,4 @@
-/**
+/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
Modified: tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/task/CUTask.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/task/CUTask.java?rev=1597056&r1=1597055&r2=1597056&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/task/CUTask.java (original)
+++ tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/task/CUTask.java Fri May 23 10:49:58 2014
@@ -1,4 +1,4 @@
-/**
+/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
Modified: tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/task/ManagedTaskListenerTask.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/task/ManagedTaskListenerTask.java?rev=1597056&r1=1597055&r2=1597056&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/task/ManagedTaskListenerTask.java (original)
+++ tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/task/ManagedTaskListenerTask.java Fri May 23 10:49:58 2014
@@ -1,4 +1,4 @@
-/**
+/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
Modified: tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/task/TriggerCallable.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/task/TriggerCallable.java?rev=1597056&r1=1597055&r2=1597056&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/task/TriggerCallable.java (original)
+++ tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/task/TriggerCallable.java Fri May 23 10:49:58 2014
@@ -1,4 +1,4 @@
-/**
+/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
Modified: tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/task/TriggerRunnable.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/task/TriggerRunnable.java?rev=1597056&r1=1597055&r2=1597056&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/task/TriggerRunnable.java (original)
+++ tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/task/TriggerRunnable.java Fri May 23 10:49:58 2014
@@ -1,4 +1,4 @@
-/**
+/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
Modified: tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/task/TriggerTask.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/task/TriggerTask.java?rev=1597056&r1=1597055&r2=1597056&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/task/TriggerTask.java (original)
+++ tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/main/java/org/apache/openejb/concurrencyutilities/ee/task/TriggerTask.java Fri May 23 10:49:58 2014
@@ -1,4 +1,4 @@
-/**
+/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
Modified: tomee/tomee/trunk/container/openejb-javaagent/src/main/java/org/apache/openejb/javaagent/Agent.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-javaagent/src/main/java/org/apache/openejb/javaagent/Agent.java?rev=1597056&r1=1597055&r2=1597056&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-javaagent/src/main/java/org/apache/openejb/javaagent/Agent.java (original)
+++ tomee/tomee/trunk/container/openejb-javaagent/src/main/java/org/apache/openejb/javaagent/Agent.java Fri May 23 10:49:58 2014
@@ -1,5 +1,4 @@
-/**
- *
+/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
@@ -9,12 +8,13 @@
*
* http://www.apache.org/licenses/LICENSE-2.0
*
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
*/
+
package org.apache.openejb.javaagent;
import java.io.*;
@@ -44,8 +44,9 @@ public class Agent {
private static boolean initialized = false;
public static void premain(final String agentArgs, final Instrumentation instrumentation) {
- if (Agent.instrumentation != null)
+ if (Agent.instrumentation != null) {
return;
+ }
Agent.agentArgs = agentArgs;
Agent.instrumentation = instrumentation;
@@ -55,8 +56,9 @@ public class Agent {
}
public static void agentmain(final String agentArgs, final Instrumentation instrumentation) {
- if (Agent.instrumentation != null)
+ if (Agent.instrumentation != null) {
return;
+ }
Agent.agentArgs = agentArgs;
Agent.instrumentation = instrumentation;
@@ -65,8 +67,9 @@ public class Agent {
public static synchronized String getAgentArgs() {
final SecurityManager sm = System.getSecurityManager();
- if (sm != null)
+ if (sm != null) {
sm.checkPermission(ACCESS_PERMISSION);
+ }
checkInitialization();
return agentArgs;
}
@@ -79,8 +82,9 @@ public class Agent {
*/
public static synchronized Instrumentation getInstrumentation() {
final SecurityManager sm = System.getSecurityManager();
- if (sm != null)
+ if (sm != null) {
sm.checkPermission(ACCESS_PERMISSION);
+ }
checkInitialization();
return instrumentation;
}
@@ -99,8 +103,9 @@ public class Agent {
}
private static void checkSystemClassPath() throws NoSuchFieldException, IllegalAccessException {
- if (instrumentation != null)
+ if (instrumentation != null) {
return;
+ }
final Class<?> systemAgentClass;
try {
@@ -121,8 +126,9 @@ public class Agent {
}
private static void dynamicLoadAgent() throws Exception {
- if (instrumentation != null)
+ if (instrumentation != null) {
return;
+ }
try {
final Class<?> vmClass = Class.forName("com.sun.tools.attach.VirtualMachine");
@@ -242,6 +248,7 @@ public class Agent {
try {
closeable.close();
} catch (IOException ignored) {
+ // no-op
}
}
}
@@ -263,8 +270,9 @@ public class Agent {
}
private void bootstrap(final ClassLoader loader) {
- if (loader == null || done)
+ if (loader == null || done) {
return;
+ }
final String bootstrapClassName = "org.apache.openejb.persistence.PersistenceBootstrap";
final String bootstrapClassFile = "org/apache/openejb/persistence/PersistenceBootstrap.class";
Modified: tomee/tomee/trunk/container/openejb-jpa-integration/src/main/java/org/apache/openejb/jpa/integration/MakeTxLookup.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-jpa-integration/src/main/java/org/apache/openejb/jpa/integration/MakeTxLookup.java?rev=1597056&r1=1597055&r2=1597056&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-jpa-integration/src/main/java/org/apache/openejb/jpa/integration/MakeTxLookup.java (original)
+++ tomee/tomee/trunk/container/openejb-jpa-integration/src/main/java/org/apache/openejb/jpa/integration/MakeTxLookup.java Fri May 23 10:49:58 2014
@@ -33,9 +33,9 @@ public class MakeTxLookup implements Opc
public static final String HIBERNATE_NEW_FACTORY2 = "org.apache.openejb.hibernate.OpenEJBJtaPlatform2";
public static final String TOPLINK_FACTORY = "org.apache.openejb.toplink.JTATransactionController";
- public static void main(String[] args) throws Exception {
+ public static void main(final String[] args) throws Exception {
- File file = new File(args[0]);
+ final File file = new File(args[0]);
createTopLinkStrategy(file);
createHibernteStrategy(file);
@@ -45,7 +45,7 @@ public class MakeTxLookup implements Opc
}
private static void createNewHibernateStrategy(final File basedir, final String target, final String abstractJtaPlatformPackage) throws Exception {
- ClassWriter cw = new ClassWriter(0);
+ final ClassWriter cw = new ClassWriter(0);
MethodVisitor mv;
cw.visit(V1_6, ACC_PUBLIC + ACC_SUPER, target.replace('.', '/'), null, abstractJtaPlatformPackage + "/AbstractJtaPlatform", null);
@@ -70,9 +70,9 @@ public class MakeTxLookup implements Opc
{
mv = cw.visitMethod(ACC_PROTECTED, "locateUserTransaction", "()Ljavax/transaction/UserTransaction;", null, null);
mv.visitCode();
- Label l0 = new Label();
- Label l1 = new Label();
- Label l2 = new Label();
+ final Label l0 = new Label();
+ final Label l1 = new Label();
+ final Label l2 = new Label();
mv.visitTryCatchBlock(l0, l1, l2, "javax/naming/NamingException");
mv.visitLabel(l0);
mv.visitMethodInsn(INVOKESTATIC, "org/apache/openejb/loader/SystemInstance", "get", "()Lorg/apache/openejb/loader/SystemInstance;", false);
@@ -98,15 +98,15 @@ public class MakeTxLookup implements Opc
write(basedir, cw, target.replace('.', '/'));
}
- private static void createHibernteStrategy(File baseDir) throws Exception {
+ private static void createHibernteStrategy(final File baseDir) throws Exception {
- String factory = HIBERNATE_FACTORY;
+ final String factory = HIBERNATE_FACTORY;
- String classFilePath = factory.replace('.', '/');
+ final String classFilePath = factory.replace('.', '/');
- String sourceFileName = factory.substring(factory.lastIndexOf('.') + 1, factory.length()) + ".java";
+ final String sourceFileName = factory.substring(factory.lastIndexOf('.') + 1, factory.length()) + ".java";
- ClassWriter cw = new ClassWriter(0);
+ final ClassWriter cw = new ClassWriter(0);
MethodVisitor mv;
cw.visit(V1_5, ACC_PUBLIC + ACC_SUPER, classFilePath, null, "java/lang/Object", new String[]{"org/hibernate/transaction/TransactionManagerLookup"});
@@ -152,16 +152,16 @@ public class MakeTxLookup implements Opc
write(baseDir, cw, classFilePath);
}
- private static void createTopLinkStrategy(File baseDir) throws Exception {
+ private static void createTopLinkStrategy(final File baseDir) throws Exception {
- String factory = TOPLINK_FACTORY;
+ final String factory = TOPLINK_FACTORY;
- String classFilePath = factory.replace('.', '/');
+ final String classFilePath = factory.replace('.', '/');
- String sourceFileName = factory.substring(factory.lastIndexOf('.') + 1, factory.length()) + ".java";
+ final String sourceFileName = factory.substring(factory.lastIndexOf('.') + 1, factory.length()) + ".java";
- ClassWriter cw = new ClassWriter(0);
+ final ClassWriter cw = new ClassWriter(0);
MethodVisitor mv;
cw.visit(V1_5, ACC_PUBLIC + ACC_SUPER, classFilePath, null, "oracle/toplink/essentials/transaction/JTATransactionController", null);
@@ -191,14 +191,14 @@ public class MakeTxLookup implements Opc
write(baseDir, cw, classFilePath);
}
- private static void write(File file, ClassWriter cw, String classFileName) throws IOException {
- classFileName = "classes/" + classFileName + ".class";
-
- for (String part : classFileName.split("/")) file = new File(file, part);
-
+ private static void write(final File originalFile, final ClassWriter cw, final String originalClassFileName) throws IOException {
+ final String classFileName = "classes/" + originalClassFileName + ".class";
+ File file = originalFile;
+ for (final String part : classFileName.split("/")) {
+ file = new File(file, part);
+ }
file.getParentFile().mkdirs();
-
- FileOutputStream out = new FileOutputStream(file);
+ final FileOutputStream out = new FileOutputStream(file);
out.write(cw.toByteArray());
out.close();
}
Modified: tomee/tomee/trunk/container/openejb-jpa-integration/src/main/java/org/apache/openejb/jpa/integration/eclipselink/PrefixSessionCustomizer.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-jpa-integration/src/main/java/org/apache/openejb/jpa/integration/eclipselink/PrefixSessionCustomizer.java?rev=1597056&r1=1597055&r2=1597056&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-jpa-integration/src/main/java/org/apache/openejb/jpa/integration/eclipselink/PrefixSessionCustomizer.java (original)
+++ tomee/tomee/trunk/container/openejb-jpa-integration/src/main/java/org/apache/openejb/jpa/integration/eclipselink/PrefixSessionCustomizer.java Fri May 23 10:49:58 2014
@@ -37,11 +37,11 @@ public class PrefixSessionCustomizer imp
if (JPAThreadContext.infos.containsKey("properties")) {
final String prefix = ((Properties) JPAThreadContext.infos.get("properties")).getProperty("openejb.jpa.table_prefix");
final List<DatabaseTable> tables = new ArrayList<DatabaseTable>();
- for (ClassDescriptor cd : session.getDescriptors().values()) {
- for (DatabaseTable table : cd.getTables()) {
+ for (final ClassDescriptor cd : session.getDescriptors().values()) {
+ for (final DatabaseTable table : cd.getTables()) {
update(prefix, tables, table);
}
- for (DatabaseMapping mapping : cd.getMappings()) {
+ for (final DatabaseMapping mapping : cd.getMappings()) {
if (mapping instanceof ManyToManyMapping) {
update(prefix, tables, ((ManyToManyMapping) mapping).getRelationTable());
} else if (mapping instanceof DirectCollectionMapping) {
Modified: tomee/tomee/trunk/container/openejb-jpa-integration/src/main/java/org/apache/openejb/jpa/integration/hibernate/PrefixNamingStrategy.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-jpa-integration/src/main/java/org/apache/openejb/jpa/integration/hibernate/PrefixNamingStrategy.java?rev=1597056&r1=1597055&r2=1597056&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-jpa-integration/src/main/java/org/apache/openejb/jpa/integration/hibernate/PrefixNamingStrategy.java (original)
+++ tomee/tomee/trunk/container/openejb-jpa-integration/src/main/java/org/apache/openejb/jpa/integration/hibernate/PrefixNamingStrategy.java Fri May 23 10:49:58 2014
@@ -30,7 +30,7 @@ public class PrefixNamingStrategy extend
}
@Override
- public String classToTableName(String className) {
+ public String classToTableName(final String className) {
return getPrefix() + super.classToTableName(className);
}
Modified: tomee/tomee/trunk/container/openejb-loader/src/main/java/org/apache/openejb/loader/ClassPathFactory.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-loader/src/main/java/org/apache/openejb/loader/ClassPathFactory.java?rev=1597056&r1=1597055&r2=1597056&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-loader/src/main/java/org/apache/openejb/loader/ClassPathFactory.java (original)
+++ tomee/tomee/trunk/container/openejb-loader/src/main/java/org/apache/openejb/loader/ClassPathFactory.java Fri May 23 10:49:58 2014
@@ -17,25 +17,16 @@
package org.apache.openejb.loader;
public class ClassPathFactory {
+ @SuppressWarnings("checkstyle:needbraces")
public static ClassPath createClassPath(final String name) {
- if (name.equalsIgnoreCase("tomcat")) {
- return new TomcatClassPath();
- } else if (name.equalsIgnoreCase("tomcat-common")) {
- return new TomcatClassPath();
- } else if (name.equalsIgnoreCase("tomcat-system")) {
- return new TomcatClassPath();
- } else if (name.equalsIgnoreCase("tomcat-webapp")) {
- return new WebAppClassPath();
- } else if (name.equalsIgnoreCase("bootstrap")) {
- return new SystemClassPath();
- } else if (name.equalsIgnoreCase("system")) {
- return new SystemClassPath();
- } else if (name.equalsIgnoreCase("thread")) {
- return new ContextClassPath();
- } else if (name.equalsIgnoreCase("context")) {
- return new ContextClassPath();
- } else {
- return new ContextClassPath();
- }
+ if (name.equalsIgnoreCase("tomcat")) return new TomcatClassPath();
+ if (name.equalsIgnoreCase("tomcat-common")) return new TomcatClassPath();
+ if (name.equalsIgnoreCase("tomcat-system")) return new TomcatClassPath();
+ if (name.equalsIgnoreCase("tomcat-webapp")) return new WebAppClassPath();
+ if (name.equalsIgnoreCase("bootstrap")) return new SystemClassPath();
+ if (name.equalsIgnoreCase("system")) return new SystemClassPath();
+ if (name.equalsIgnoreCase("thread")) return new ContextClassPath();
+ if (name.equalsIgnoreCase("context")) return new ContextClassPath();
+ return new ContextClassPath();
}
}
Modified: tomee/tomee/trunk/pom.xml
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/pom.xml?rev=1597056&r1=1597055&r2=1597056&view=diff
==============================================================================
--- tomee/tomee/trunk/pom.xml (original)
+++ tomee/tomee/trunk/pom.xml Fri May 23 10:49:58 2014
@@ -445,6 +445,9 @@
<module>container/openejb-core</module>
<module>container/openejb-loader</module>
<module>container/openejb-junit</module>
+ <module>container/openejb-jpa-integration</module>
+ <module>container/openejb-javaagent</module>
+ <module>container/openejb-api</module>
</modules>
<properties>
<style.config.dir>${user.dir}/src/main/style</style.config.dir>
Modified: tomee/tomee/trunk/src/main/style/checkstyle.xml
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/src/main/style/checkstyle.xml?rev=1597056&r1=1597055&r2=1597056&view=diff
==============================================================================
--- tomee/tomee/trunk/src/main/style/checkstyle.xml (original)
+++ tomee/tomee/trunk/src/main/style/checkstyle.xml Fri May 23 10:49:58 2014
@@ -38,6 +38,8 @@
<!-- Following interprets the header file as regular expressions. -->
<!-- <module name="RegexpHeader"/> -->
+ <module name="SuppressWarningsFilter" />
+
<module name="FileTabCharacter">
<property name="eachLine" value="true"/>
</module>
@@ -56,6 +58,7 @@
</module>
<module name="TreeWalker">
+ <module name="SuppressWarningsHolder" />
<property name="cacheFile" value="${checkstyle.cache.file}"/>