You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by "Shanthoosh Venkataraman (JIRA)" <ji...@apache.org> on 2019/03/19 21:01:00 UTC

[jira] [Updated] (SAMZA-2133) Fix the broken TestKeyValuePerformance test.

     [ https://issues.apache.org/jira/browse/SAMZA-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shanthoosh Venkataraman updated SAMZA-2133:
-------------------------------------------
    Description: 
Running the TestJeyValuePerformance test results in the following failure:
{noformat}
2019-03-19 11:16:36.713 [main] TestKeyValuePerformance$ [INFO] Running test: rocksdb-write-performance
Exception in thread "main" java.lang.IllegalArgumentException: Job name is not defined in configuration
 at org.apache.samza.context.JobContextImpl.fromConfigWithDefaults(JobContextImpl.java:49)
 at org.apache.samza.test.performance.TestKeyValuePerformance$$anonfun$invokeTest$2$$anonfun$apply$1.apply$mcVI$sp(TestKeyValuePerformance.scala:126)
 at scala.collection.immutable.Range.foreach$mVc$sp(Range.scala:160)
 at org.apache.samza.test.performance.TestKeyValuePerformance$$anonfun$invokeTest$2.apply(TestKeyValuePerformance.scala:114)
 at org.apache.samza.test.performance.TestKeyValuePerformance$$anonfun$invokeTest$2.apply(TestKeyValuePerformance.scala:112)
 at scala.collection.TraversableLike$WithFilter$$anonfun$foreach$1.apply(TraversableLike.scala:733)
 at scala.collection.mutable.ResizableArray$class.foreach(ResizableArray.scala:59)
 at scala.collection.mutable.ArrayBuffer.foreach(ArrayBuffer.scala:48)
 at scala.collection.TraversableLike$WithFilter.foreach(TraversableLike.scala:732)
 at org.apache.samza.test.performance.TestKeyValuePerformance$.invokeTest(TestKeyValuePerformance.scala:112)
 at org.apache.samza.test.performance.TestKeyValuePerformance$$anonfun$main$1.apply(TestKeyValuePerformance.scala:80)
 at org.apache.samza.test.performance.TestKeyValuePerformance$$anonfun$main$1.apply(TestKeyValuePerformance.scala:77)
 at scala.collection.IndexedSeqOptimized$class.foreach(IndexedSeqOptimized.scala:33)
 at scala.collection.mutable.ArrayOps$ofRef.foreach(ArrayOps.scala:186)
 at org.apache.samza.test.performance.TestKeyValuePerformance$.main(TestKeyValuePerformance.scala:77)
 at org.apache.samza.test.performance.TestKeyValuePerformance.main(TestKeyValuePerformance.scala)
:samza-shell:kvPerformanceTest FAILED
{noformat}
Through SAMZA-1714, we added a verification in`JobContextImpl` to validate the presence of the `JobId`, `JobName` in configuration. JobId, JobName configurations are not populated in configurations of TestKeyValuePerformance before launching the test.

The fix is to add the two configuration jobId, jobName in the configuration before launching the test.

  was:
Running the TestJeyValuePerformance test results in the following failure:

{noformat}
2019-03-19 11:16:36.713 [main] TestKeyValuePerformance$ [INFO] Running test: rocksdb-write-performance
Exception in thread "main" java.lang.IllegalArgumentException: Job name is not defined in configuration
 at org.apache.samza.context.JobContextImpl.fromConfigWithDefaults(JobContextImpl.java:49)
 at org.apache.samza.test.performance.TestKeyValuePerformance$$anonfun$invokeTest$2$$anonfun$apply$1.apply$mcVI$sp(TestKeyValuePerformance.scala:126)
 at scala.collection.immutable.Range.foreach$mVc$sp(Range.scala:160)
 at org.apache.samza.test.performance.TestKeyValuePerformance$$anonfun$invokeTest$2.apply(TestKeyValuePerformance.scala:114)
 at org.apache.samza.test.performance.TestKeyValuePerformance$$anonfun$invokeTest$2.apply(TestKeyValuePerformance.scala:112)
 at scala.collection.TraversableLike$WithFilter$$anonfun$foreach$1.apply(TraversableLike.scala:733)
 at scala.collection.mutable.ResizableArray$class.foreach(ResizableArray.scala:59)
 at scala.collection.mutable.ArrayBuffer.foreach(ArrayBuffer.scala:48)
 at scala.collection.TraversableLike$WithFilter.foreach(TraversableLike.scala:732)
 at org.apache.samza.test.performance.TestKeyValuePerformance$.invokeTest(TestKeyValuePerformance.scala:112)
 at org.apache.samza.test.performance.TestKeyValuePerformance$$anonfun$main$1.apply(TestKeyValuePerformance.scala:80)
 at org.apache.samza.test.performance.TestKeyValuePerformance$$anonfun$main$1.apply(TestKeyValuePerformance.scala:77)
 at scala.collection.IndexedSeqOptimized$class.foreach(IndexedSeqOptimized.scala:33)
 at scala.collection.mutable.ArrayOps$ofRef.foreach(ArrayOps.scala:186)
 at org.apache.samza.test.performance.TestKeyValuePerformance$.main(TestKeyValuePerformance.scala:77)
 at org.apache.samza.test.performance.TestKeyValuePerformance.main(TestKeyValuePerformance.scala)
:samza-shell:kvPerformanceTest FAILED
{noformat}

Through SAMZA-1714, we added a verification in`JobContextImpl` to validate the presence of the `JobId`, `JobName` in configuration.

The fix is to add the two configuration jobId, jobName in the configuration before launching the test.


> Fix the broken TestKeyValuePerformance test.
> --------------------------------------------
>
>                 Key: SAMZA-2133
>                 URL: https://issues.apache.org/jira/browse/SAMZA-2133
>             Project: Samza
>          Issue Type: Bug
>            Reporter: Shanthoosh Venkataraman
>            Assignee: Shanthoosh Venkataraman
>            Priority: Major
>
> Running the TestJeyValuePerformance test results in the following failure:
> {noformat}
> 2019-03-19 11:16:36.713 [main] TestKeyValuePerformance$ [INFO] Running test: rocksdb-write-performance
> Exception in thread "main" java.lang.IllegalArgumentException: Job name is not defined in configuration
>  at org.apache.samza.context.JobContextImpl.fromConfigWithDefaults(JobContextImpl.java:49)
>  at org.apache.samza.test.performance.TestKeyValuePerformance$$anonfun$invokeTest$2$$anonfun$apply$1.apply$mcVI$sp(TestKeyValuePerformance.scala:126)
>  at scala.collection.immutable.Range.foreach$mVc$sp(Range.scala:160)
>  at org.apache.samza.test.performance.TestKeyValuePerformance$$anonfun$invokeTest$2.apply(TestKeyValuePerformance.scala:114)
>  at org.apache.samza.test.performance.TestKeyValuePerformance$$anonfun$invokeTest$2.apply(TestKeyValuePerformance.scala:112)
>  at scala.collection.TraversableLike$WithFilter$$anonfun$foreach$1.apply(TraversableLike.scala:733)
>  at scala.collection.mutable.ResizableArray$class.foreach(ResizableArray.scala:59)
>  at scala.collection.mutable.ArrayBuffer.foreach(ArrayBuffer.scala:48)
>  at scala.collection.TraversableLike$WithFilter.foreach(TraversableLike.scala:732)
>  at org.apache.samza.test.performance.TestKeyValuePerformance$.invokeTest(TestKeyValuePerformance.scala:112)
>  at org.apache.samza.test.performance.TestKeyValuePerformance$$anonfun$main$1.apply(TestKeyValuePerformance.scala:80)
>  at org.apache.samza.test.performance.TestKeyValuePerformance$$anonfun$main$1.apply(TestKeyValuePerformance.scala:77)
>  at scala.collection.IndexedSeqOptimized$class.foreach(IndexedSeqOptimized.scala:33)
>  at scala.collection.mutable.ArrayOps$ofRef.foreach(ArrayOps.scala:186)
>  at org.apache.samza.test.performance.TestKeyValuePerformance$.main(TestKeyValuePerformance.scala:77)
>  at org.apache.samza.test.performance.TestKeyValuePerformance.main(TestKeyValuePerformance.scala)
> :samza-shell:kvPerformanceTest FAILED
> {noformat}
> Through SAMZA-1714, we added a verification in`JobContextImpl` to validate the presence of the `JobId`, `JobName` in configuration. JobId, JobName configurations are not populated in configurations of TestKeyValuePerformance before launching the test.
> The fix is to add the two configuration jobId, jobName in the configuration before launching the test.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)