You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "David Li (Jira)" <ji...@apache.org> on 2022/07/08 20:56:00 UTC

[jira] [Closed] (ARROW-13664) [Developer] Append better merge visibility to merge_arrow_pr.py

     [ https://issues.apache.org/jira/browse/ARROW-13664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Li closed ARROW-13664.
----------------------------
      Assignee: Kouhei Sutou
    Resolution: Fixed

This was fixed when we changed to using the GitHub API to merge pull requests.

 

> [Developer] Append better merge visibility to merge_arrow_pr.py
> ---------------------------------------------------------------
>
>                 Key: ARROW-13664
>                 URL: https://issues.apache.org/jira/browse/ARROW-13664
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: Developer Tools
>            Reporter: Ben Kietzman
>            Assignee: Kouhei Sutou
>            Priority: Major
>
> dev/merge_arrow_pr.py is a nifty tool, but due to the way it avoids use of a GitHub-sanctioned merge it frequently confuses newcomers who see "closed" instead of "merged" PRs.
> This could be ameliorated by automatically adding a comment to the PR directly after the "closed" event explaining that the PR is in fact merged and linking to an full breakdown of our alternative git flow.
> Additionally for visibility in contexts where only the PR headline is visible it'd be useful to attach a "merged" label and/or place a [MERGED] tag in the title



--
This message was sent by Atlassian Jira
(v8.20.10#820010)