You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "John J. Franey (JIRA)" <ji...@apache.org> on 2009/03/20 18:22:50 UTC
[jira] Created: (DIRMINA-680) PortUnreachableException ought not to
schedule session shutdown
PortUnreachableException ought not to schedule session shutdown
---------------------------------------------------------------
Key: DIRMINA-680
URL: https://issues.apache.org/jira/browse/DIRMINA-680
Project: MINA
Issue Type: Improvement
Components: Core
Affects Versions: 2.0.0-M4
Reporter: John J. Franey
I wonder if you would entertain the idea that the PortUnreachableException should be handled in the IoHandler by the 'application', at least for datagram applications.
I'm working on an RTP implementation which is datagram based. I'm still naive about RTP, but it seems reasonable for media to be sent prematurely, or the for the remote port to be down temporarily. I would like to have the option to temporarily suspend transmission on the socket, as opposed to have to 'reconnect' the datagram socket.
Thanks,
John
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (DIRMINA-680) PortUnreachableException ought not
to schedule session shutdown
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emmanuel Lecharny reopened DIRMINA-680:
---------------------------------------
It now fails on my laptop :
-------------------------------------------------------------------------------
Test set: org.apache.mina.transport.socket.nio.DatagramPortUnreachableTest
-------------------------------------------------------------------------------
Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.07 sec <<< FAILURE!
testPortUnreachableClosesSession(org.apache.mina.transport.socket.nio.DatagramPortUnreachableTest) Time elapsed: 0.027 sec <<< FAILURE!
junit.framework.AssertionFailedError: expected:<true> but was:<false>
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.failNotEquals(Assert.java:277)
at junit.framework.Assert.assertEquals(Assert.java:64)
at junit.framework.Assert.assertEquals(Assert.java:143)
at junit.framework.Assert.assertEquals(Assert.java:149)
at org.apache.mina.transport.socket.nio.DatagramPortUnreachableTest.runTest(DatagramPortUnreachableTest.java:60)
at org.apache.mina.transport.socket.nio.DatagramPortUnreachableTest.testPortUnreachableClosesSession(DatagramPortUnreachableTest.java:66)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at junit.framework.TestCase.runTest(TestCase.java:168)
at junit.framework.TestCase.runBare(TestCase.java:134)
at junit.framework.TestResult$1.protect(TestResult.java:110)
at junit.framework.TestResult.runProtected(TestResult.java:128)
at junit.framework.TestResult.run(TestResult.java:113)
at junit.framework.TestCase.run(TestCase.java:124)
at junit.framework.TestSuite.runTest(TestSuite.java:232)
at junit.framework.TestSuite.run(TestSuite.java:227)
at org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:81)
at org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:62)
at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:140)
at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:127)
at org.apache.maven.surefire.Surefire.run(Surefire.java:177)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:345)
at org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:1009)
> PortUnreachableException ought not to schedule session shutdown
> ---------------------------------------------------------------
>
> Key: DIRMINA-680
> URL: https://issues.apache.org/jira/browse/DIRMINA-680
> Project: MINA
> Issue Type: Improvement
> Components: Core
> Affects Versions: 2.0.0-M4
> Reporter: John J. Franey
> Assignee: Edouard De Oliveira
> Fix For: 2.0.0-M7
>
> Attachments: pure.txt
>
>
> I wonder if you would entertain the idea that the PortUnreachableException should be handled in the IoHandler by the 'application', at least for datagram applications.
> I'm working on an RTP implementation which is datagram based. I'm still naive about RTP, but it seems reasonable for media to be sent prematurely, or the for the remote port to be down temporarily. I would like to have the option to temporarily suspend transmission on the socket, as opposed to have to 'reconnect' the datagram socket.
> Thanks,
> John
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DIRMINA-680) PortUnreachableException ought not to
schedule session shutdown
Posted by "John J. Franey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John J. Franey updated DIRMINA-680:
-----------------------------------
Attachment: pure.txt
here is a diff relatvie to svn revision: 756463. Showing the PortUnreachableException being handed up to IoHandler instead of causing session to be removed.
> PortUnreachableException ought not to schedule session shutdown
> ---------------------------------------------------------------
>
> Key: DIRMINA-680
> URL: https://issues.apache.org/jira/browse/DIRMINA-680
> Project: MINA
> Issue Type: Improvement
> Components: Core
> Affects Versions: 2.0.0-M4
> Reporter: John J. Franey
> Attachments: pure.txt
>
>
> I wonder if you would entertain the idea that the PortUnreachableException should be handled in the IoHandler by the 'application', at least for datagram applications.
> I'm working on an RTP implementation which is datagram based. I'm still naive about RTP, but it seems reasonable for media to be sent prematurely, or the for the remote port to be down temporarily. I would like to have the option to temporarily suspend transmission on the socket, as opposed to have to 'reconnect' the datagram socket.
> Thanks,
> John
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DIRMINA-680) PortUnreachableException ought not to
schedule session shutdown
Posted by "Edouard De Oliveira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edouard De Oliveira updated DIRMINA-680:
----------------------------------------
Fix Version/s: (was: 2.0.0-RC1)
2.0.0-M7
I propose that we add an option to the AbstractDatagramSessionConfig class to set the way PortUnreachableException should be handled. If we keep closing the session by default it won't change anything for existing code.
> PortUnreachableException ought not to schedule session shutdown
> ---------------------------------------------------------------
>
> Key: DIRMINA-680
> URL: https://issues.apache.org/jira/browse/DIRMINA-680
> Project: MINA
> Issue Type: Improvement
> Components: Core
> Affects Versions: 2.0.0-M4
> Reporter: John J. Franey
> Assignee: Edouard De Oliveira
> Fix For: 2.0.0-M7
>
> Attachments: pure.txt
>
>
> I wonder if you would entertain the idea that the PortUnreachableException should be handled in the IoHandler by the 'application', at least for datagram applications.
> I'm working on an RTP implementation which is datagram based. I'm still naive about RTP, but it seems reasonable for media to be sent prematurely, or the for the remote port to be down temporarily. I would like to have the option to temporarily suspend transmission on the socket, as opposed to have to 'reconnect' the datagram socket.
> Thanks,
> John
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (DIRMINA-680) PortUnreachableException ought not to
schedule session shutdown
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emmanuel Lecharny closed DIRMINA-680.
-------------------------------------
> PortUnreachableException ought not to schedule session shutdown
> ---------------------------------------------------------------
>
> Key: DIRMINA-680
> URL: https://issues.apache.org/jira/browse/DIRMINA-680
> Project: MINA
> Issue Type: Improvement
> Components: Core
> Affects Versions: 2.0.0-M4
> Reporter: John J. Franey
> Assignee: Edouard De Oliveira
> Fix For: 2.0.0-RC1
>
> Attachments: pure.txt
>
>
> I wonder if you would entertain the idea that the PortUnreachableException should be handled in the IoHandler by the 'application', at least for datagram applications.
> I'm working on an RTP implementation which is datagram based. I'm still naive about RTP, but it seems reasonable for media to be sent prematurely, or the for the remote port to be down temporarily. I would like to have the option to temporarily suspend transmission on the socket, as opposed to have to 'reconnect' the datagram socket.
> Thanks,
> John
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DIRMINA-680) PortUnreachableException ought not
to schedule session shutdown
Posted by "Edouard De Oliveira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edouard De Oliveira resolved DIRMINA-680.
-----------------------------------------
Resolution: Fixed
> PortUnreachableException ought not to schedule session shutdown
> ---------------------------------------------------------------
>
> Key: DIRMINA-680
> URL: https://issues.apache.org/jira/browse/DIRMINA-680
> Project: MINA
> Issue Type: Improvement
> Components: Core
> Affects Versions: 2.0.0-M4
> Reporter: John J. Franey
> Assignee: Edouard De Oliveira
> Fix For: 2.0.0-M7
>
> Attachments: pure.txt
>
>
> I wonder if you would entertain the idea that the PortUnreachableException should be handled in the IoHandler by the 'application', at least for datagram applications.
> I'm working on an RTP implementation which is datagram based. I'm still naive about RTP, but it seems reasonable for media to be sent prematurely, or the for the remote port to be down temporarily. I would like to have the option to temporarily suspend transmission on the socket, as opposed to have to 'reconnect' the datagram socket.
> Thanks,
> John
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (DIRMINA-680) PortUnreachableException ought not
to schedule session shutdown
Posted by "Edouard De Oliveira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edouard De Oliveira reassigned DIRMINA-680:
-------------------------------------------
Assignee: Edouard De Oliveira
> PortUnreachableException ought not to schedule session shutdown
> ---------------------------------------------------------------
>
> Key: DIRMINA-680
> URL: https://issues.apache.org/jira/browse/DIRMINA-680
> Project: MINA
> Issue Type: Improvement
> Components: Core
> Affects Versions: 2.0.0-M4
> Reporter: John J. Franey
> Assignee: Edouard De Oliveira
> Fix For: 2.0.0-RC1
>
> Attachments: pure.txt
>
>
> I wonder if you would entertain the idea that the PortUnreachableException should be handled in the IoHandler by the 'application', at least for datagram applications.
> I'm working on an RTP implementation which is datagram based. I'm still naive about RTP, but it seems reasonable for media to be sent prematurely, or the for the remote port to be down temporarily. I would like to have the option to temporarily suspend transmission on the socket, as opposed to have to 'reconnect' the datagram socket.
> Thanks,
> John
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DIRMINA-680) PortUnreachableException ought not
to schedule session shutdown
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emmanuel Lecharny resolved DIRMINA-680.
---------------------------------------
Resolution: Fixed
Fixed with :
http://svn.apache.org/viewvc?rev=784887&view=rev
> PortUnreachableException ought not to schedule session shutdown
> ---------------------------------------------------------------
>
> Key: DIRMINA-680
> URL: https://issues.apache.org/jira/browse/DIRMINA-680
> Project: MINA
> Issue Type: Improvement
> Components: Core
> Affects Versions: 2.0.0-M4
> Reporter: John J. Franey
> Assignee: Edouard De Oliveira
> Fix For: 2.0.0-M7
>
> Attachments: pure.txt
>
>
> I wonder if you would entertain the idea that the PortUnreachableException should be handled in the IoHandler by the 'application', at least for datagram applications.
> I'm working on an RTP implementation which is datagram based. I'm still naive about RTP, but it seems reasonable for media to be sent prematurely, or the for the remote port to be down temporarily. I would like to have the option to temporarily suspend transmission on the socket, as opposed to have to 'reconnect' the datagram socket.
> Thanks,
> John
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DIRMINA-680) PortUnreachableException ought not to
schedule session shutdown
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emmanuel Lecharny updated DIRMINA-680:
--------------------------------------
Fix Version/s: 2.0.0-RC1
let's see if this patch can be applied in 2.0.0-RC1
> PortUnreachableException ought not to schedule session shutdown
> ---------------------------------------------------------------
>
> Key: DIRMINA-680
> URL: https://issues.apache.org/jira/browse/DIRMINA-680
> Project: MINA
> Issue Type: Improvement
> Components: Core
> Affects Versions: 2.0.0-M4
> Reporter: John J. Franey
> Fix For: 2.0.0-RC1
>
> Attachments: pure.txt
>
>
> I wonder if you would entertain the idea that the PortUnreachableException should be handled in the IoHandler by the 'application', at least for datagram applications.
> I'm working on an RTP implementation which is datagram based. I'm still naive about RTP, but it seems reasonable for media to be sent prematurely, or the for the remote port to be down temporarily. I would like to have the option to temporarily suspend transmission on the socket, as opposed to have to 'reconnect' the datagram socket.
> Thanks,
> John
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.