You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-dev@jackrabbit.apache.org by "rishabhdaim (via GitHub)" <gi...@apache.org> on 2024/08/28 17:38:45 UTC
[PR] OAK-11068 : added fullGcMode to oak-run [jackrabbit-oak]
rishabhdaim opened a new pull request, #1674:
URL: https://github.com/apache/jackrabbit-oak/pull/1674
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-11068 : added fullGcMode to oak-run [jackrabbit-oak]
Posted by "rishabhdaim (via GitHub)" <gi...@apache.org>.
rishabhdaim commented on code in PR #1674:
URL: https://github.com/apache/jackrabbit-oak/pull/1674#discussion_r1735067822
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java:
##########
@@ -121,7 +121,7 @@ public class VersionGarbageCollector {
private static final String STATUS_IDLE = "IDLE";
private static final String STATUS_INITIALIZING = "INITIALIZING";
private static final Logger log = getLogger(VersionGarbageCollector.class);
- private static final Logger AUDIT_LOG = getLogger(VersionGarbageCollector.class.getName() + ".auditDGC");
+ private static final Logger AUDIT_LOG = getLogger(VersionGarbageCollector.class.getName() + ".auditFGC");
Review Comment:
renamed logger from DGC -> FGC
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-11068 : added fullGcMode to oak-run [jackrabbit-oak]
Posted by "rishabhdaim (via GitHub)" <gi...@apache.org>.
rishabhdaim commented on code in PR #1674:
URL: https://github.com/apache/jackrabbit-oak/pull/1674#discussion_r1735068183
##########
oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollectorIT.java:
##########
@@ -1914,7 +1914,7 @@ public void testUnmergedBCRootCleanup() throws Exception {
createSecondaryStore(LeaseCheckMode.LENIENT);
// while "2" was written to node1/a via an unmerged branch commit,
- // it should not have been made visible through DGC/sweep combo
+ // it should not have been made visible through FGC/sweep combo
Review Comment:
minor correction of DGC -> FGC
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-11068 : added fullGcMode to oak-run [jackrabbit-oak]
Posted by "rishabhdaim (via GitHub)" <gi...@apache.org>.
rishabhdaim merged PR #1674:
URL: https://github.com/apache/jackrabbit-oak/pull/1674
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-11068 : added fullGcMode to oak-run [jackrabbit-oak]
Posted by "rishabhdaim (via GitHub)" <gi...@apache.org>.
rishabhdaim commented on code in PR #1674:
URL: https://github.com/apache/jackrabbit-oak/pull/1674#discussion_r1735067296
##########
oak-run/src/main/java/org/apache/jackrabbit/oak/run/RevisionsCommand.java:
##########
@@ -103,7 +103,7 @@ public class RevisionsCommand implements Command {
private static final List<String> LOGGER_NAMES = of(
"org.apache.jackrabbit.oak.plugins.document.VersionGarbageCollector",
"org.apache.jackrabbit.oak.plugins.document.NodeDocumentSweeper",
- "org.apache.jackrabbit.oak.plugins.document.VersionGarbageCollector.auditDGC",
+ "org.apache.jackrabbit.oak.plugins.document.VersionGarbageCollector.auditFGC",
Review Comment:
changed the last bit of DGC -> FGC
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org