[jira] [Closed] (AMQ-6844) Misleading args order

["Timothy Bish (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/AMQ-6844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Timothy Bish closed AMQ-6844.
-----------------------------
    Resolution: Not A Problem

These are two different connection factories from two different JMS client implementations so it's fine for them to be different and I don't see either project wanting to change existing code.  If you use JNDI to create your JMS resources you won't be affected by this.  

> Misleading args order
> ---------------------
>
>                 Key: AMQ-6844
>                 URL: https://issues.apache.org/jira/browse/AMQ-6844
>             Project: ActiveMQ
>          Issue Type: Improvement
>          Components: JMS client
>    Affects Versions: 5.15.1
>            Reporter: guai
>
> org.apache.activemq.artemis.jms.client.ActiveMQConnectionFactory: 
> public ActiveMQConnectionFactory(String url, String user, String password) {...}
> org.apache.activemq.ActiveMQConnectionFactory:
> public ActiveMQConnectionFactory(String userName, String password, String brokerURL) {...}
> all three are strings, url first vs url last can cause problems while migrating and compiler won't even notice.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)