You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/08/04 00:13:46 UTC

[GitHub] [skywalking] JaredTan95 commented on a change in pull request #7399: Support Metric level function `serviceRelation` in `MAL` and binding envoy metrics into the topology.

JaredTan95 commented on a change in pull request #7399:
URL: https://github.com/apache/skywalking/pull/7399#discussion_r682181841



##########
File path: oap-server/server-bootstrap/src/main/resources/envoy-metrics-rules/envoy.yaml
##########
@@ -61,17 +61,17 @@ metricsRules:
     # envoy_cluster_metrics
   - name: cluster_membership_healthy
     exp: envoy_cluster_metrics.tagMatch('metrics_name' , '.+membership_healthy').tagMatch('metrics_name' , 'cluster.outbound.+|cluster.inbound.+').tagNotMatch('cluster_name' , '.+kube-system').sum(['app', 'instance' , 'cluster_name'])
-  - name: cluster_upstream_cx_active

Review comment:
       Whether the metric name can be consistent with the original before?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org