You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/06/16 12:59:54 UTC
[GitHub] [camel-k] ammachado opened a new pull request, #3367: Backport 3363 to 1.8
ammachado opened a new pull request, #3367:
URL: https://github.com/apache/camel-k/pull/3367
<!-- Description -->
<!--
Enter your extended release note in the below block. If the PR requires
additional action from users switching to the new release, include the string
"action required". If no release note is required, write "NONE".
You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->
**Release Note**
```release-note
fix(cli): fix panic while running kamel local run on Windows
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi merged pull request #3367: Backport 3363 to 1.8
Posted by GitBox <gi...@apache.org>.
tadayosi merged PR #3367:
URL: https://github.com/apache/camel-k/pull/3367
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi commented on a diff in pull request #3367: Backport 3363 to 1.8
Posted by GitBox <gi...@apache.org>.
tadayosi commented on code in PR #3367:
URL: https://github.com/apache/camel-k/pull/3367#discussion_r899081527
##########
pkg/resources/resources_support.go:
##########
@@ -146,3 +148,7 @@ func Resources(dirName string) ([]string, error) {
return res, dir.Close()
}
+
+func openAsset(path string) (http.File, error) {
+ return assets.Open(filepath.FromSlash(path))
Review Comment:
ditto
##########
pkg/resources/resources_support.go:
##########
@@ -103,8 +104,9 @@ func WithPrefix(pathPrefix string) ([]string, error) {
var res []string
for i := range paths {
- if result, _ := filepath.Match(pathPrefix+"*", paths[i]); result {
- res = append(res, paths[i])
+ path := filepath.FromSlash(paths[i])
Review Comment:
Shouldn't this be `filepath.ToSlash()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org