You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/23 06:45:56 UTC
[GitHub] [incubator-superset] mistercrunch opened a new pull request #11011: style(explore): use tertiary button against gray background
mistercrunch opened a new pull request #11011:
URL: https://github.com/apache/incubator-superset/pull/11011
"primary" style buttons seem to expect a white background and really
look muted against the gray background. Using "tertiary" style button makes
things much better.
Eventually we may reconsider the layout and gray background and go back
to secondary, but for now this makes these important pop much more
## after
<img width="567" alt="Screen Shot 2020-09-22 at 11 45 29 PM" src="https://user-images.githubusercontent.com/487433/93976342-b6c5e680-fd2d-11ea-80ea-5e6324d8af50.png">
## before
<img width="574" alt="Screen Shot 2020-09-22 at 11 41 03 PM" src="https://user-images.githubusercontent.com/487433/93976305-a57cda00-fd2d-11ea-8d04-b4404b0f1001.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on pull request #11011: style(explore): use tertiary button against gray background
Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #11011:
URL: https://github.com/apache/incubator-superset/pull/11011#issuecomment-697869843
Seconding the "revisit" plan btw. Future designs of Explore have these buttons on a white background... when we get there we should switch 'em back.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas merged pull request #11011: style(explore): use tertiary button against gray background
Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #11011:
URL: https://github.com/apache/incubator-superset/pull/11011
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org