You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2018/08/20 22:37:15 UTC

[GitHub] kaxil edited a comment on issue #3733: [AIRFLOW-491] Add cache parameter in BigQuery query method - with 'src_fmt_configs'

kaxil edited a comment on issue #3733: [AIRFLOW-491] Add cache parameter in BigQuery query method - with 'src_fmt_configs'
URL: https://github.com/apache/incubator-airflow/pull/3733#issuecomment-414485773
 
 
   @tswast @xnuinside Sorry guys, after reviewing the `src_fmt_configs` in other BigQuery operators I noticed that it is actually used to add `configs` related to data source i.e. the configs for `CSV`, `AVRO`. 
   
   https://github.com/apache/incubator-airflow/blob/master/airflow/contrib/hooks/bigquery_hook.py#L414-L454
   
   So, I think for this PR, `src_fmt_configs` doesn't matter as we are going to query data. @xnuinside Can you please name it to `api_resource_configs` or `extra_api_configs`.
   
   What name sounds better to you guys @tswast @fenglu-g ?
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services