[GitHub] [netbeans] jGauravGupta commented on a change in pull request #1484: JEDDICT-322 org.netbeans.modules.maven convert friend to public packages

[GitBox <gi...@apache.org>]

jGauravGupta commented on a change in pull request #1484: JEDDICT-322 org.netbeans.modules.maven convert friend to public packages
URL: https://github.com/apache/netbeans/pull/1484#discussion_r341853571
 
 

 ##########
 File path: java/maven/nbproject/project.xml
 ##########
 @@ -636,6 +592,7 @@
                 <package>org.netbeans.modules.maven.api.execute</package>
                 <package>org.netbeans.modules.maven.api.output</package>
                 <package>org.netbeans.modules.maven.api.problem</package>
+                <package>org.netbeans.modules.maven.configurations</package>
                 <package>org.netbeans.modules.maven.execute</package>
 
 Review comment:
   AFAIK both friend and public APIs can't be defined in the same module.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists