[GitHub] [spark] Kimahriman commented on pull request #35959: [SPARK-38640][CORE] Fix NPE with memory-only cache blocks and RDD fetching

[GitBox <gi...@apache.org>]

Kimahriman commented on pull request #35959:
URL: https://github.com/apache/spark/pull/35959#issuecomment-1077545449


   I wasn't exactly sure what the "right" fix was here that avoided weird edge cases where you change a block from memory only to memory and disk or vice versa. The alternative is adding a null check in `BlockStatusPerBlockId.remove` but I wasn't sure if that was a race condition waiting to happen or if that will only ever be called from one thread. But I guess the `get` would also be a race condition if that was the case, so maybe that's the better alternative?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org