You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by ol...@apache.org on 2006/03/11 19:33:25 UTC
svn commit: r385120 - in /jakarta/httpcomponents/trunk/http-core/src:
java/org/apache/http/util/EncodingUtils.java
java/org/apache/http/util/ExceptionUtils.java
java/org/apache/http/util/LangUtils.java
test/org/apache/http/io/TestCharArrayBuffer.java
Author: olegk
Date: Sat Mar 11 10:33:23 2006
New Revision: 385120
URL: http://svn.apache.org/viewcvs?rev=385120&view=rev
Log:
More test coverage
Modified:
jakarta/httpcomponents/trunk/http-core/src/java/org/apache/http/util/EncodingUtils.java
jakarta/httpcomponents/trunk/http-core/src/java/org/apache/http/util/ExceptionUtils.java
jakarta/httpcomponents/trunk/http-core/src/java/org/apache/http/util/LangUtils.java
jakarta/httpcomponents/trunk/http-core/src/test/org/apache/http/io/TestCharArrayBuffer.java
Modified: jakarta/httpcomponents/trunk/http-core/src/java/org/apache/http/util/EncodingUtils.java
URL: http://svn.apache.org/viewcvs/jakarta/httpcomponents/trunk/http-core/src/java/org/apache/http/util/EncodingUtils.java?rev=385120&r1=385119&r2=385120&view=diff
==============================================================================
--- jakarta/httpcomponents/trunk/http-core/src/java/org/apache/http/util/EncodingUtils.java (original)
+++ jakarta/httpcomponents/trunk/http-core/src/java/org/apache/http/util/EncodingUtils.java Sat Mar 11 10:33:23 2006
@@ -190,7 +190,6 @@
* This class should not be instantiated.
*/
private EncodingUtils() {
- super();
}
}
Modified: jakarta/httpcomponents/trunk/http-core/src/java/org/apache/http/util/ExceptionUtils.java
URL: http://svn.apache.org/viewcvs/jakarta/httpcomponents/trunk/http-core/src/java/org/apache/http/util/ExceptionUtils.java?rev=385120&r1=385119&r2=385120&view=diff
==============================================================================
--- jakarta/httpcomponents/trunk/http-core/src/java/org/apache/http/util/ExceptionUtils.java (original)
+++ jakarta/httpcomponents/trunk/http-core/src/java/org/apache/http/util/ExceptionUtils.java Sat Mar 11 10:33:23 2006
@@ -77,4 +77,7 @@
}
}
+ private ExceptionUtils() {
+ }
+
}
Modified: jakarta/httpcomponents/trunk/http-core/src/java/org/apache/http/util/LangUtils.java
URL: http://svn.apache.org/viewcvs/jakarta/httpcomponents/trunk/http-core/src/java/org/apache/http/util/LangUtils.java?rev=385120&r1=385119&r2=385120&view=diff
==============================================================================
--- jakarta/httpcomponents/trunk/http-core/src/java/org/apache/http/util/LangUtils.java (original)
+++ jakarta/httpcomponents/trunk/http-core/src/java/org/apache/http/util/LangUtils.java Sat Mar 11 10:33:23 2006
@@ -43,7 +43,6 @@
public static int HASH_OFFSET = 37;
private LangUtils() {
- super();
}
public static int hashCode(final int seed, final int hashcode) {
Modified: jakarta/httpcomponents/trunk/http-core/src/test/org/apache/http/io/TestCharArrayBuffer.java
URL: http://svn.apache.org/viewcvs/jakarta/httpcomponents/trunk/http-core/src/test/org/apache/http/io/TestCharArrayBuffer.java?rev=385120&r1=385119&r2=385120&view=diff
==============================================================================
--- jakarta/httpcomponents/trunk/http-core/src/test/org/apache/http/io/TestCharArrayBuffer.java (original)
+++ jakarta/httpcomponents/trunk/http-core/src/test/org/apache/http/io/TestCharArrayBuffer.java Sat Mar 11 10:33:23 2006
@@ -304,6 +304,21 @@
assertEquals("stuff and more stuff", buffer.toString());
}
+ public void testAppendISOByteArray() throws Exception {
+ byte[] b = new byte[] {0x00, 0x20, 0x7F, -0x80, -0x01};
+
+ CharArrayBuffer buffer = new CharArrayBuffer(8);
+ buffer.append(b, 0, b.length);
+ char[] ch = buffer.toCharArray();
+ assertNotNull(ch);
+ assertEquals(5, ch.length);
+ assertEquals(0x00, ch[0]);
+ assertEquals(0x20, ch[1]);
+ assertEquals(0x7F, ch[2]);
+ assertEquals(0x80, ch[3]);
+ assertEquals(0xFF, ch[4]);
+ }
+
public void testAppendNullByteArray() throws Exception {
CharArrayBuffer buffer = new CharArrayBuffer(8);
buffer.append((byte[])null, 0, 0);