You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/08/10 21:52:54 UTC

[GitHub] [beam] pabloem commented on pull request #15126: [BEAM-12665] Add option in ReadAll Transforms to add filename to the output

pabloem commented on pull request #15126:
URL: https://github.com/apache/beam/pull/15126#issuecomment-896338004


   this LGTM.
   Why did we change `with_context` to `with_filename`? Maybe context could return an object with further context? (e.g. partition, line name, etc)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org