[jira] [Comment Edited] (SLING-3006) SlingServletResolver webconsole plugin uses custom URL decomposition code that can be wrong

["Bertrand Delacretaz (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13734944#comment-13734944 ] 

Bertrand Delacretaz edited comment on SLING-3006 at 8/9/13 4:11 PM:
--------------------------------------------------------------------

Fixed in http://svn.apache.org/r1512369 by using the SlingRequestPathInfo class that's used in request processing in the webconsole plugin.

The plugin can still potentially get out of sync with the actual request processing code as I'm embedding that class in the resolver bundle instead of using it via a service, but using the "official" URL decomposition code gives it a much better chance of being correct.
                
      was (Author: bdelacretaz):
    Fixed in http://svn.apache.org/r1512369 by using the SlingRequestPathInfo class that's used in request processing in the webconsole plugin.

The plugin can still potentially get out of sync with the actual request processing code as I'm embedding that class in the resolver bundle, but using the "official" URL decomposition code gives it a much better chance of being correct.
                  
> SlingServletResolver webconsole plugin uses custom URL decomposition code that can be wrong
> -------------------------------------------------------------------------------------------
>
>                 Key: SLING-3006
>                 URL: https://issues.apache.org/jira/browse/SLING-3006
>             Project: Sling
>          Issue Type: Bug
>          Components: Servlets
>    Affects Versions: Servlets Resolver 2.2.4
>            Reporter: Bertrand Delacretaz
>            Assignee: Bertrand Delacretaz
>            Priority: Minor
>             Fix For: Servlets Resolver 2.2.6
>
>
> Entering http://localhost:8080/libs/foo/content/something/formitems.json/image/vnd/xnd/knd.xml in the /system/console/servletresolver webconsole plugin does not produce the correct results as per the testDotsAroundSuffix() at [1]
> This is due to the plugin using its own DecomposedURL class which is a simplified version of the SlingRequestPathInfo class.
> For now, I'll add a warning to the plugin.
> [1] http://svn.apache.org/repos/asf/sling/trunk/bundles/engine/src/test/java/org/apache/sling/engine/impl/request/SlingRequestPathInfoTest.java

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira