[GitHub] [solr] laminelam commented on pull request #1798: Add/fix wrong/missing "solr.home" to zkcli scripts

["laminelam (via GitHub)" <gi...@apache.org>]

laminelam commented on PR #1798:
URL: https://github.com/apache/solr/pull/1798#issuecomment-1673715418

   > Thanks for looking at this.. one thought, would you want to add some BATS test to confirm these fixes? They have been great for verifying a lot of the SolrCLI things... Down the road, I hope to eliminate the need for the `zkcli.sh` completely, in favour of using `bin/solr` commands... Having some BATS tests would help that migration ;-).
   
   Hi @epugh 
   Thanks for the great suggestion. Didn't know about BATS.
   I have added a couple of BATS tests to test both 'solr,home" and "solrhome" options.
   Wondering if it's worth it keeping "solr.home" option, it's redundant and confusing 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org