You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Dong Lin <li...@gmail.com> on 2014/08/20 02:15:29 UTC

Review Request 24874: Patch for KAFKA-1601

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24874/
-----------------------------------------------------------

Review request for kafka.


Bugs: KAFKA-1601
    https://issues.apache.org/jira/browse/KAFKA-1601


Repository: kafka


Description
-------

KAFKA-1601; ConsoleConsumer/SimpleConsumerPerformance should be transaction-aware


Diffs
-----

  core/src/main/scala/kafka/consumer/ConsumerTransactionBuffer.scala PRE-CREATION 
  core/src/main/scala/kafka/message/MessageAndMetadata.scala d693abc620aef7030f29f915604c5e172d60da0d 
  core/src/main/scala/kafka/tools/ConsoleConsumer.scala 323fc8566d974acc4e5c7d7c2a065794f3b5df4a 
  core/src/main/scala/kafka/tools/SimpleConsumerPerformance.scala 7602b8d705970a5dab49ed36d117346a960701ac 

Diff: https://reviews.apache.org/r/24874/diff/


Testing
-------


Thanks,

Dong Lin


Re: Review Request 24874: Patch for KAFKA-1604

Posted by Dong Lin <li...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24874/
-----------------------------------------------------------

(Updated Aug. 20, 2014, 4:07 a.m.)


Review request for kafka.


Summary (updated)
-----------------

Patch for KAFKA-1604


Bugs: KAFKA-1601 and KAFKA-1604
    https://issues.apache.org/jira/browse/KAFKA-1601
    https://issues.apache.org/jira/browse/KAFKA-1604


Repository: kafka


Description (updated)
-------

KAFKA-1604; System Test for Transaction Management


Diffs (updated)
-----

  system_test/transaction_testsuite/cluster_config.json PRE-CREATION 
  system_test/transaction_testsuite/config/console_consumer.properties PRE-CREATION 
  system_test/transaction_testsuite/config/producer_performance.properties PRE-CREATION 
  system_test/transaction_testsuite/config/server.properties PRE-CREATION 
  system_test/transaction_testsuite/config/zookeeper.properties PRE-CREATION 
  system_test/transaction_testsuite/testcase_20001/testcase_20001_properties.json PRE-CREATION 
  system_test/transaction_testsuite/transaction_test.py PRE-CREATION 
  system_test/utils/kafka_system_test_utils.py 6edd64a92ce749421b5ab60fbea5b55e2ccbfe94 

Diff: https://reviews.apache.org/r/24874/diff/


Testing
-------


Thanks,

Dong Lin


Re: Review Request 24874: Patch for KAFKA-1601

Posted by Dong Lin <li...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24874/
-----------------------------------------------------------

(Updated Aug. 20, 2014, 4:06 a.m.)


Review request for kafka.


Summary (updated)
-----------------

Patch for KAFKA-1601


Bugs: KAFKA-1601 and KAFKA-1604
    https://issues.apache.org/jira/browse/KAFKA-1601
    https://issues.apache.org/jira/browse/KAFKA-1604


Repository: kafka


Description (updated)
-------

KAFKA-1601; ConsoleConsumer/SimpleConsumerPerformance should be transaction-aware


Diffs (updated)
-----

  core/src/main/scala/kafka/consumer/TransactionBuffer.scala PRE-CREATION 
  core/src/main/scala/kafka/message/MessageAndMetadata.scala d693abc620aef7030f29f915604c5e172d60da0d 
  core/src/main/scala/kafka/tools/ConsoleConsumer.scala 323fc8566d974acc4e5c7d7c2a065794f3b5df4a 
  core/src/main/scala/kafka/tools/SimpleConsumerPerformance.scala 7602b8d705970a5dab49ed36d117346a960701ac 

Diff: https://reviews.apache.org/r/24874/diff/


Testing
-------


Thanks,

Dong Lin


Re: Review Request 24874: Patch for KAFKA-1604

Posted by Dong Lin <li...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24874/
-----------------------------------------------------------

(Updated Aug. 20, 2014, 12:31 a.m.)


Review request for kafka.


Bugs: KAFKA-1601 and KAFKA-1604
    https://issues.apache.org/jira/browse/KAFKA-1601
    https://issues.apache.org/jira/browse/KAFKA-1604


Repository: kafka


Description (updated)
-------

KAFKA-1604; System Test for Transaction Management


Diffs (updated)
-----

  system_test/transaction_testsuite/cluster_config.json PRE-CREATION 
  system_test/transaction_testsuite/config/console_consumer.properties PRE-CREATION 
  system_test/transaction_testsuite/config/producer_performance.properties PRE-CREATION 
  system_test/transaction_testsuite/config/server.properties PRE-CREATION 
  system_test/transaction_testsuite/config/zookeeper.properties PRE-CREATION 
  system_test/transaction_testsuite/testcase_20001/testcase_20001_properties.json PRE-CREATION 
  system_test/transaction_testsuite/transaction_test.py PRE-CREATION 
  system_test/utils/kafka_system_test_utils.py 6edd64a92ce749421b5ab60fbea5b55e2ccbfe94 

Diff: https://reviews.apache.org/r/24874/diff/


Testing
-------


Thanks,

Dong Lin


Re: Review Request 24874: Patch for KAFKA-1604

Posted by Dong Lin <li...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24874/
-----------------------------------------------------------

(Updated Aug. 20, 2014, 12:28 a.m.)


Review request for kafka.


Bugs: KAFKA-1601 and KAFKA-1604
    https://issues.apache.org/jira/browse/KAFKA-1601
    https://issues.apache.org/jira/browse/KAFKA-1604


Repository: kafka


Description (updated)
-------

KAFKA-1601; ConsoleConsumer/SimpleConsumerPerformance should be transaction-aware


Diffs (updated)
-----

  core/src/main/scala/kafka/consumer/ConsumerTransactionBuffer.scala PRE-CREATION 
  core/src/main/scala/kafka/message/MessageAndMetadata.scala d693abc620aef7030f29f915604c5e172d60da0d 
  core/src/main/scala/kafka/tools/ConsoleConsumer.scala 323fc8566d974acc4e5c7d7c2a065794f3b5df4a 
  core/src/main/scala/kafka/tools/SimpleConsumerPerformance.scala 7602b8d705970a5dab49ed36d117346a960701ac 

Diff: https://reviews.apache.org/r/24874/diff/


Testing
-------


Thanks,

Dong Lin


Re: Review Request 24874: Patch for KAFKA-1604

Posted by Dong Lin <li...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24874/
-----------------------------------------------------------

(Updated Aug. 20, 2014, 12:19 a.m.)


Review request for kafka.


Summary (updated)
-----------------

Patch for KAFKA-1604


Bugs: KAFKA-1601
    https://issues.apache.org/jira/browse/KAFKA-1601


Repository: kafka


Description
-------

KAFKA-1604; System Test for Transaction Management


Diffs
-----

  core/src/main/scala/kafka/consumer/ConsumerTransactionBuffer.scala PRE-CREATION 
  core/src/main/scala/kafka/message/MessageAndMetadata.scala d693abc620aef7030f29f915604c5e172d60da0d 
  core/src/main/scala/kafka/tools/ConsoleConsumer.scala 323fc8566d974acc4e5c7d7c2a065794f3b5df4a 
  core/src/main/scala/kafka/tools/SimpleConsumerPerformance.scala 7602b8d705970a5dab49ed36d117346a960701ac 

Diff: https://reviews.apache.org/r/24874/diff/


Testing
-------


Thanks,

Dong Lin


Re: Review Request 24874: Patch for KAFKA-1601

Posted by Dong Lin <li...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24874/
-----------------------------------------------------------

(Updated Aug. 20, 2014, 12:18 a.m.)


Review request for kafka.


Bugs: KAFKA-1601
    https://issues.apache.org/jira/browse/KAFKA-1601


Repository: kafka


Description (updated)
-------

KAFKA-1604; System Test for Transaction Management


Diffs
-----

  core/src/main/scala/kafka/consumer/ConsumerTransactionBuffer.scala PRE-CREATION 
  core/src/main/scala/kafka/message/MessageAndMetadata.scala d693abc620aef7030f29f915604c5e172d60da0d 
  core/src/main/scala/kafka/tools/ConsoleConsumer.scala 323fc8566d974acc4e5c7d7c2a065794f3b5df4a 
  core/src/main/scala/kafka/tools/SimpleConsumerPerformance.scala 7602b8d705970a5dab49ed36d117346a960701ac 

Diff: https://reviews.apache.org/r/24874/diff/


Testing
-------


Thanks,

Dong Lin