[GitHub] [incubator-pegasus] Smityz commented on a change in pull request #601: feat(hotspot): add a function to start hotkey detecting in hotspot_partition_calculator

[GitBox <gi...@apache.org>]

Smityz commented on a change in pull request #601:
URL: https://github.com/apache/incubator-pegasus/pull/601#discussion_r488045237



##########
File path: src/server/hotspot_partition_calculator.cpp
##########
@@ -98,5 +103,49 @@ void hotspot_partition_calculator::data_analyse()
     }
 }
 
+/*static*/ void hotspot_partition_calculator::server_hotkey_detect_send(
+    const std::string &app_name,
+    const int partition_index,
+    const hotkey_detect_type write_hotkey_detect,
+    const hotkey_detect_action stop_detect_hotkey)

Review comment:
       `stop_detect_hotkey` is clearer to understand this variable I think




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org