[GitHub] [incubator-livy] yiheng commented on a change in pull request #254: [LIVY-706] ThriftServer does not actually cancel jobs if we Interrupt querys from beeline

[GitBox <gi...@apache.org>]

yiheng commented on a change in pull request #254: [LIVY-706] ThriftServer does not actually cancel jobs if we Interrupt querys from beeline
URL: https://github.com/apache/incubator-livy/pull/254#discussion_r343982812
 
 

 ##########
 File path: thriftserver/session/src/main/java/org/apache/livy/thriftserver/session/ThriftSessionState.java
 ##########
 @@ -103,12 +103,11 @@ StatementState findStatement(String statementId) {
 
   boolean cleanupStatement(String statementId) {
     checkNotNull(statementId, "No statement ID.");
+    ctx.sc().cancelJobGroup(statementId);
 
 Review comment:
   Don't quite understand the change here? Why move the cancelJobGroup before the ```if else``` check? What if cancel a canceled job group?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services