You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/12/21 17:52:00 UTC

[GitHub] [solr] patsonluk commented on pull request #1242: SOLR-16580: Avoid making copies of DocCollection for PRS updates

patsonluk commented on PR #1242:
URL: https://github.com/apache/solr/pull/1242#issuecomment-1361754709

   > @justinrsweeney @patsonluk this is still WIP , reviews are welcome
   
   Thanks for the work @noblepaul ! Just want to confirm that there are mainly 2 goals here:
   1. Avoid making copies of DocCollections when `copyWith` is called (related to PRS updates)
   2. Avoid fetching PRS states until the state is actually queried (the Lazy PRS provider part)
   
   Do we know the general overhead of the current designs and whether they are causing issues? I agree that both changes will for sure reduce resource usage!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org