[GitHub] [incubator-superset] bryanck commented on a change in pull request #10475: fix(dashboard): add animation state to fix tab switch re-renders

[GitBox <gi...@apache.org>]

bryanck commented on a change in pull request #10475:
URL: https://github.com/apache/incubator-superset/pull/10475#discussion_r463183889



##########
File path: superset-frontend/src/chart/ChartContainer.jsx
##########
@@ -23,6 +23,11 @@ import * as actions from './chartAction';
 import { logEvent } from '../logger/actions';
 import Chart from './Chart';
 
+function mapStateToProps({ dashboardState }) {
+  // needed to prevent chart from rendering while animating
+  return { isParentMounted: dashboardState?.isTabMounted || true };

Review comment:
       Won't this always be `true`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org