You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Steven Parkes (JIRA)" <ji...@apache.org> on 2007/07/17 20:48:04 UTC
[jira] Created: (LUCENE-962) I/O exception in DocsWriter add or
updateDocument may not delete unreferenced files
I/O exception in DocsWriter add or updateDocument may not delete unreferenced files
-----------------------------------------------------------------------------------
Key: LUCENE-962
URL: https://issues.apache.org/jira/browse/LUCENE-962
Project: Lucene - Java
Issue Type: Bug
Affects Versions: 2.2
Reporter: Steven Parkes
Assignee: Steven Parkes
Priority: Minor
Fix For: 2.3
If an I/O exception is thrown in DocumentsWriter#addDocument or #updateDocument, the stored fields files may not be cleaned up.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Resolved: (LUCENE-962) I/O exception in DocsWriter add or
updateDocument may not delete unreferenced files
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless resolved LUCENE-962.
---------------------------------------
Resolution: Fixed
Lucene Fields: [New, Patch Available] (was: [Patch Available, New])
> I/O exception in DocsWriter add or updateDocument may not delete unreferenced files
> -----------------------------------------------------------------------------------
>
> Key: LUCENE-962
> URL: https://issues.apache.org/jira/browse/LUCENE-962
> Project: Lucene - Java
> Issue Type: Bug
> Affects Versions: 2.2
> Reporter: Steven Parkes
> Assignee: Steven Parkes
> Priority: Minor
> Fix For: 2.3
>
> Attachments: LUCENE-962.patch.txt
>
>
> If an I/O exception is thrown in DocumentsWriter#addDocument or #updateDocument, the stored fields files may not be cleaned up.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-962) I/O exception in DocsWriter add or
updateDocument may not delete unreferenced files
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12513390 ]
Michael McCandless commented on LUCENE-962:
-------------------------------------------
Good catch Steven!
I think where you put the try/finally is good. The only tiny thing I
noticed is in your unit test when you create the MockRAMDirectory you
don't have to pass in an empty RAMDirectory; you can just use the
no-argument constructor instead.
I will commit this.
> I/O exception in DocsWriter add or updateDocument may not delete unreferenced files
> -----------------------------------------------------------------------------------
>
> Key: LUCENE-962
> URL: https://issues.apache.org/jira/browse/LUCENE-962
> Project: Lucene - Java
> Issue Type: Bug
> Affects Versions: 2.2
> Reporter: Steven Parkes
> Assignee: Steven Parkes
> Priority: Minor
> Fix For: 2.3
>
> Attachments: LUCENE-962.patch.txt
>
>
> If an I/O exception is thrown in DocumentsWriter#addDocument or #updateDocument, the stored fields files may not be cleaned up.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-962) I/O exception in DocsWriter add or
updateDocument may not delete unreferenced files
Posted by "Steven Parkes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steven Parkes updated LUCENE-962:
---------------------------------
Attachment: LUCENE-962.patch.txt
Patch adds wrappers in IndexWriter to catch exceptions thrown in docswriter and to call deleter.refresh before passing the exception back to the caller.
Adds a test.
I might have possibly not picked the best place to do that catch ...
> I/O exception in DocsWriter add or updateDocument may not delete unreferenced files
> -----------------------------------------------------------------------------------
>
> Key: LUCENE-962
> URL: https://issues.apache.org/jira/browse/LUCENE-962
> Project: Lucene - Java
> Issue Type: Bug
> Affects Versions: 2.2
> Reporter: Steven Parkes
> Assignee: Steven Parkes
> Priority: Minor
> Fix For: 2.3
>
> Attachments: LUCENE-962.patch.txt
>
>
> If an I/O exception is thrown in DocumentsWriter#addDocument or #updateDocument, the stored fields files may not be cleaned up.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org