You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by "Jan Lehnardt (JIRA)" <ji...@apache.org> on 2012/12/21 22:27:12 UTC
[jira] [Commented] (COUCHDB-1628) THANKS generation uses a
non-portable sed extended regexp flag
[ https://issues.apache.org/jira/browse/COUCHDB-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13538426#comment-13538426 ]
Jan Lehnardt commented on COUCHDB-1628:
---------------------------------------
Good catch!
Which Linux / see version to you see this with? I can’t seem to reproduce this on Ubuntu 11.10 & sed 4.2.1. It appears to silently ignore the -E and and still do the right thing.
> THANKS generation uses a non-portable sed extended regexp flag
> --------------------------------------------------------------
>
> Key: COUCHDB-1628
> URL: https://issues.apache.org/jira/browse/COUCHDB-1628
> Project: CouchDB
> Issue Type: Bug
> Components: Build System
> Reporter: Christopher Bonhage
> Assignee: Jan Lehnardt
> Attachments: 0001-Fix-BSD-GNU-sed-extended-regex-flag-inconsistency.patch
>
>
> The bootstrap script currently generates a THANKS file by grepping through the git shortlog and running an extended regular expression command on the resulting stream using sed (line 48):
> git shortlog -se 6c976bd..HEAD \
> | grep -v @apache.org \
> | sed -E "s/^[[:blank:]]{5}[[:digit:]]+[[:blank:]]/ * /" >> THANKS
> BSD sed uses the '-E' option to interpret regular expressions as extended (modern) regular expressions rather than basic regular expressions (BRE's). GNU sed uses the '-r' option for this behavior.
> The bootstrap script should be modified to detect the proper flag to use. I am currently using a patch which checks the system's uname to determine the flag.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira