You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Veena Basavaraj <vb...@cloudera.com> on 2014/11/04 18:21:15 UTC
Review Request 27577: SQOOP-1673DOC: Update Upgrade.rst to reflect the
latest in the code
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27577/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SQOOP-1673
https://issues.apache.org/jira/browse/SQOOP-1673
Repository: sqoop-sqoop2
Description
-------
see jira
https://issues.apache.org/jira/browse/SQOOP-1673
Diffs
-----
docs/src/site/sphinx/Upgrade.rst aa3316c
Diff: https://reviews.apache.org/r/27577/diff/
Testing
-------
Thanks,
Veena Basavaraj
Re: Review Request 27577: SQOOP-1673DOC: Update Upgrade.rst to
reflect the latest in the code
Posted by Veena Basavaraj <vb...@cloudera.com>.
> On Nov. 4, 2014, 9:27 a.m., Gwen Shapira wrote:
> > docs/src/site/sphinx/Upgrade.rst, line 52
> > <https://reviews.apache.org/r/27577/diff/1/?file=748383#file748383line52>
> >
> > Not just schema upgrade, right? the upgrade may modify content as well.
> >
> > BTW. Since we are re-writing the docs - maybe advise on taking backups prior to upgrade?
the immutable flag applies only to the schema upgrade
the connector and driver means data as well, I will make it more explicit.
thanks
- Veena
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27577/#review59778
-----------------------------------------------------------
On Nov. 4, 2014, 9:21 a.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27577/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2014, 9:21 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1673
> https://issues.apache.org/jira/browse/SQOOP-1673
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see jira
>
> https://issues.apache.org/jira/browse/SQOOP-1673
>
>
> Diffs
> -----
>
> docs/src/site/sphinx/Upgrade.rst aa3316c
>
> Diff: https://reviews.apache.org/r/27577/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27577: SQOOP-1673DOC: Update Upgrade.rst to
reflect the latest in the code
Posted by Gwen Shapira <gs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27577/#review59778
-----------------------------------------------------------
Ship it!
Looks great, just few comments.
docs/src/site/sphinx/Upgrade.rst
<https://reviews.apache.org/r/27577/#comment101080>
Not sure we should mention "configurables" here - its an "internals" term that won't be clear to users.
docs/src/site/sphinx/Upgrade.rst
<https://reviews.apache.org/r/27577/#comment101081>
Not just schema upgrade, right? the upgrade may modify content as well.
BTW. Since we are re-writing the docs - maybe advise on taking backups prior to upgrade?
- Gwen Shapira
On Nov. 4, 2014, 5:21 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27577/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2014, 5:21 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1673
> https://issues.apache.org/jira/browse/SQOOP-1673
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see jira
>
> https://issues.apache.org/jira/browse/SQOOP-1673
>
>
> Diffs
> -----
>
> docs/src/site/sphinx/Upgrade.rst aa3316c
>
> Diff: https://reviews.apache.org/r/27577/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27577: SQOOP-1675 : DOC: Update Upgrade.rst to
reflect the latest in the code
Posted by Gwen Shapira <gs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27577/#review59787
-----------------------------------------------------------
Ship it!
Ship It!
- Gwen Shapira
On Nov. 4, 2014, 6:11 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27577/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2014, 6:11 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1675
> https://issues.apache.org/jira/browse/SQOOP-1675
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see jira
>
> SQOOP-1675
>
>
> Diffs
> -----
>
> docs/src/site/sphinx/Upgrade.rst a59c3a0
>
> Diff: https://reviews.apache.org/r/27577/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27577: SQOOP-1675 : DOC: Update Upgrade.rst to
reflect the latest in the code
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27577/
-----------------------------------------------------------
(Updated Nov. 4, 2014, 10:11 a.m.)
Review request for Sqoop.
Bugs: SQOOP-1675
https://issues.apache.org/jira/browse/SQOOP-1675
Repository: sqoop-sqoop2
Description
-------
see jira
SQOOP-1675
Diffs (updated)
-----
docs/src/site/sphinx/Upgrade.rst a59c3a0
Diff: https://reviews.apache.org/r/27577/diff/
Testing
-------
Thanks,
Veena Basavaraj
Re: Review Request 27577: SQOOP-1675 : DOC: Update Upgrade.rst to
reflect the latest in the code
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27577/
-----------------------------------------------------------
(Updated Nov. 4, 2014, 9:58 a.m.)
Review request for Sqoop.
Summary (updated)
-----------------
SQOOP-1675 : DOC: Update Upgrade.rst to reflect the latest in the code
Bugs: SQOOP-1675
https://issues.apache.org/jira/browse/SQOOP-1675
Repository: sqoop-sqoop2
Description (updated)
-------
see jira
SQOOP-1675
Diffs
-----
docs/src/site/sphinx/Upgrade.rst aa3316c
Diff: https://reviews.apache.org/r/27577/diff/
Testing
-------
Thanks,
Veena Basavaraj