[GitHub] [incubator-echarts] plainheart commented on pull request #13390: [5.0] [Feature] sunburst series supports cornerRadius

[GitBox <gi...@apache.org>]

plainheart commented on pull request #13390:
URL: https://github.com/apache/incubator-echarts/pull/13390#issuecomment-705536378


   > Do we name it as `borderRaidus` as CSS did or name it as `cornerRadius`?
   
   I thought about the naming at first.
   Though I would like to name it after `borderRadius` to keep naming uniform, I think `cornerRadius` is more suitable for the sector shape and is more semantic. Moreover, I found most of chart libraries call it `cornerRadius`, such as [amcharts](https://www.amcharts.com/docs/v4/reference/slice/#cornerRadius_property), [d3](https://github.com/d3/d3-shape#arc_cornerRadius).
   However, on the contrary, `borderRadius` is more corresponding with the naming of `border` in CSS.
   I'm afraid it's hard for me to decide to use which one.
   
   > Should `cornerRadius` be set in `itemStyle` as `borderColor` `borderWidth` did or set in the root of `series`? Probably it's better to follow the convention to put it in `itemStyle`?
   
   I think it's generally okay. Putting `cornerRadius` into `itemStyle` may enable users to control easily style of each item(sector).
   That looks better.
   
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org