You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jclouds.apache.org by Everett Toews <no...@github.com> on 2013/07/03 23:25:35 UTC

[jclouds.github.com] Make links to styles/images relative. (#148)

This should allow the site to be deployed at any level in a directory hierarchy and it will still render correctly because the style/image links are relative. In particular it should appear correctly in the Jenkins workspace when the site gets built.
You can merge this Pull Request by running:

  git pull https://github.com/rackerlabs/jclouds.github.com relative-style

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds.github.com/pull/148

-- Commit Summary --

  * Make links to styles/images relative.

-- File Changes --

    M _layouts/index.html (7)
    M _layouts/jclouds.html (7)

-- Patch Links --

https://github.com/jclouds/jclouds.github.com/pull/148.patch
https://github.com/jclouds/jclouds.github.com/pull/148.diff


Re: [jclouds.github.com] Make links to styles/images relative. (#148)

Posted by BuildHive <no...@github.com>.
[jclouds » jclouds.github.com #53](https://buildhive.cloudbees.com/job/jclouds/job/jclouds.github.com/53/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds.github.com/pull/148#issuecomment-20445968

Re: [jclouds.github.com] Make links to styles/images relative. (#148)

Posted by BuildHive <no...@github.com>.
[jclouds » jclouds.github.com #56](https://buildhive.cloudbees.com/job/jclouds/job/jclouds.github.com/56/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds.github.com/pull/148#issuecomment-20480467

Re: [jclouds.github.com] Make links to styles/images relative. (#148)

Posted by Everett Toews <no...@github.com>.
Hmmm...looks like the links to other resources within the site will also need to be made relative too.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds.github.com/pull/148#issuecomment-20446410

Re: [jclouds.github.com] Make links to styles/images relative. (#148)

Posted by Everett Toews <no...@github.com>.
I'm going to continue testing solutions with jekyll as I don't think I've exhausted all of the options yet. I'll definitely be happy to chat about it at the meetup.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds.github.com/pull/148#issuecomment-20448364

Re: [jclouds.github.com] Make links to styles/images relative. (#148)

Posted by Ignasi Barrera <no...@github.com>.
>In particular it should appear correctly in the Jenkins workspace when the site gets built.

Great!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds.github.com/pull/148#issuecomment-20446078

Re: [jclouds.github.com] Make links to styles/images relative. (#148)

Posted by Matt Stephenson <no...@github.com>.
I don't think this is the cleanest approach, you could probably write a bit of jquery when the page is loaded.  We can chat more when we're at the meetup.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds.github.com/pull/148#issuecomment-20446842

Re: [jclouds.github.com] Make links to styles/images relative. (#148)

Posted by BuildHive <no...@github.com>.
[jclouds » jclouds.github.com #55](https://buildhive.cloudbees.com/job/jclouds/job/jclouds.github.com/55/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds.github.com/pull/148#issuecomment-20479203