You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/12/29 13:03:23 UTC
[GitHub] [dubbo-samples] daimingbao opened a new pull request #195: improve the dubbo-samples-mock test case
daimingbao opened a new pull request #195:
URL: https://github.com/apache/dubbo-samples/pull/195
improve the dubbo-samples-mock test case
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] kylixs commented on pull request #195: improve the dubbo-samples-mock test case
Posted by GitBox <gi...@apache.org>.
kylixs commented on pull request #195:
URL: https://github.com/apache/dubbo-samples/pull/195#issuecomment-752650670
It's fine
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] chickenlj merged pull request #195: improve the dubbo-samples-mock test case
Posted by GitBox <gi...@apache.org>.
chickenlj merged pull request #195:
URL: https://github.com/apache/dubbo-samples/pull/195
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] kylixs commented on a change in pull request #195: improve the dubbo-samples-mock test case
Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #195:
URL: https://github.com/apache/dubbo-samples/pull/195#discussion_r550191990
##########
File path: dubbo-samples-mock/pom.xml
##########
@@ -33,60 +33,68 @@
<dubbo.version>2.7.7</dubbo.version>
<slf4j-log4j12.version>1.7.25</slf4j-log4j12.version>
Review comment:
slf4j-log4j12.version、javax.annotation.version这种属性去掉
##########
File path: dubbo-samples-mock/pom.xml
##########
@@ -96,7 +104,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
- <version>3.7.0</version>
+ <version>${maven-compiler-plugin.version}</version>
Review comment:
不需要抽取maven-compiler-plugin.version属性
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org