Re: cvs commit: apache-2.0/src/lib/apr/include apr_file_io.h

[Ryan Bloom <rb...@ntrnet.net>]

On 13 Oct 1999 bhyde@hyperreal.org wrote:

> bhyde       99/10/13 13:33:43
> 
>   Modified:    src/lib/apr/include apr_file_io.h
>   Log:
>   Mr. -Wall, full of opinions.
>   
>   Revision  Changes    Path
>   1.14      +1 -1      apache-2.0/src/lib/apr/include/apr_file_io.h
>   
>   Index: apr_file_io.h
>   ===================================================================
>   RCS file: /home/cvs/apache-2.0/src/lib/apr/include/apr_file_io.h,v
>   retrieving revision 1.13
>   retrieving revision 1.14
>   diff -u -r1.13 -r1.14
>   --- apr_file_io.h	1999/10/13 15:29:18	1.13
>   +++ apr_file_io.h	1999/10/13 20:33:42	1.14
>   @@ -130,7 +130,7 @@
>    API_EXPORT(int) ap_fprintf(ap_file_t *fptr, const char *format, ...)
>            __attribute__((format(printf,2,3)));
>    
>   -ap_status_t ap_make_iov(ap_iovec_t **, struct iovec *, ap_context_t *);
>   +ap_status_t ap_make_iov(ap_iovec_t **, ap_iovec_t *, ap_context_t *);

This is wrong.  There is no way somebody could have an ap_iovec_t to pass
into this function as the second argument, because this function is
creating the instance of ap_iovec_t.

I'll fix it tomorrow.

Ryan

_______________________________________________________________________________
Ryan Bloom                        	rbb@ntrnet.net
6209 H Shanda Dr.
Raleigh, NC 27609		Ryan Bloom -- thinker, adventurer, artist,
				     writer, but mostly, friend.
-------------------------------------------------------------------------------

Re: cvs commit: apache-2.0/src/lib/apr/include apr_file_io.h

[Ben Hyde <bh...@pobox.com>]

Ryan Bloom <rb...@ntrnet.net> writes:

> On 13 Oct 1999 bhyde@hyperreal.org wrote:
...
> >   -ap_status_t ap_make_iov(ap_iovec_t **, struct iovec *, ap_context_t *);
> >   +ap_status_t ap_make_iov(ap_iovec_t **, ap_iovec_t *, ap_context_t *);
> 
> This is wrong.  ...

I backed it out, somethings wrong, but it wasn't what I thought. - ben