[GitHub] [druid] clintropolis commented on a diff in pull request #13089: Add JsonInputFormat option to assume newline delimited JSON, improve parse exception handling for multiline JSON

[GitBox <gi...@apache.org>]

clintropolis commented on code in PR #13089:
URL: https://github.com/apache/druid/pull/13089#discussion_r978581828


##########
core/src/main/java/org/apache/druid/data/input/impl/JsonInputFormat.java:
##########
@@ -85,6 +106,8 @@ public JsonInputFormat(
       objectMapper.configure(feature, entry.getValue());
     }
     this.lineSplittable = lineSplittable;
+    this.assumeNewlineDelimited = assumeNewlineDelimited != null && assumeNewlineDelimited;
+    this.useJsonNodeReader = useJsonNodeReader != null && useJsonNodeReader;

Review Comment:
   seems like maybe it would be an error to indicate `useJsonNodeReader` if `assumeNewLineDelimted` is set, though ignoring it seems ok too :shrug:



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org