You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Mahadev konar (JIRA)" <ji...@apache.org> on 2009/02/25 02:32:01 UTC
[jira] Created: (ZOOKEEPER-330) zookeeper standalone server does
not startup with just a port and datadir.
zookeeper standalone server does not startup with just a port and datadir.
--------------------------------------------------------------------------
Key: ZOOKEEPER-330
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-330
Project: Zookeeper
Issue Type: Bug
Affects Versions: 3.1.1, 3.2.0
Reporter: Mahadev konar
Assignee: Mahadev konar
Priority: Blocker
Fix For: 3.1.1, 3.2.0
ZOOKEEPER-326 made a change to zookeeperservermain.java that broke the starting of zookeeperserver with just the port and datadir.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-330) zookeeper standalone server does
not startup with just a port and datadir.
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12676482#action_12676482 ]
Mahadev konar commented on ZOOKEEPER-330:
-----------------------------------------
also the c tests fail to run right now since the api for ZookeeperServerMain changed. Now it passes again with the patch.
> zookeeper standalone server does not startup with just a port and datadir.
> --------------------------------------------------------------------------
>
> Key: ZOOKEEPER-330
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-330
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.1.1, 3.2.0
> Reporter: Mahadev konar
> Assignee: Mahadev konar
> Priority: Blocker
> Fix For: 3.1.1, 3.2.0
>
> Attachments: ZOOKEEPER-330.patch
>
>
> ZOOKEEPER-326 made a change to zookeeperservermain.java that broke the starting of zookeeperserver with just the port and datadir.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-330) zookeeper standalone server does
not startup with just a port and datadir.
Posted by "Chris Darroch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Darroch updated ZOOKEEPER-330:
------------------------------------
Attachment: ZOOKEEPER-330.patch
Sorry I didn't catch the problem with src/c/tests/zkServer.sh invoking ZooKeeperMain directly.
The only issue I had with your proposed patch here is that the original problem I encountered in ZOOKEEPER-326 returns -- if you start a standalone server using QuorumPeerMain, it ignores tickTime settings there again. This contradicts the information here:
http://hadoop.apache.org/zookeeper/docs/r3.1.0/zookeeperStarted.html#sc_InstallingSingleMode
and it also just would be nice, I think, for the standard zkServer.sh (which uses QuorumPeerMain) and standard config file to work fully for standalone installations out of the box.
My revisions in the attached patch allow ZooKeeperMain to take a single config file as an alternate set of arguments, in which case it works like QuorumPeerMain. This seems to resolve both my original issue, support the addition of a command-line tickTime argument as per your patch, and allow the src/c/tests/zkServer.sh script to work as-is.
> zookeeper standalone server does not startup with just a port and datadir.
> --------------------------------------------------------------------------
>
> Key: ZOOKEEPER-330
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-330
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.1.1, 3.2.0
> Reporter: Mahadev konar
> Assignee: Mahadev konar
> Priority: Blocker
> Fix For: 3.1.1, 3.2.0
>
> Attachments: ZOOKEEPER-330.patch, ZOOKEEPER-330.patch
>
>
> ZOOKEEPER-326 made a change to zookeeperservermain.java that broke the starting of zookeeperserver with just the port and datadir.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-330) zookeeper standalone server does
not startup with just a port and datadir.
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-330:
------------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this. Thanks chris.
> zookeeper standalone server does not startup with just a port and datadir.
> --------------------------------------------------------------------------
>
> Key: ZOOKEEPER-330
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-330
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.1.1, 3.2.0
> Reporter: Mahadev konar
> Assignee: Mahadev konar
> Priority: Blocker
> Fix For: 3.1.1, 3.2.0
>
> Attachments: ZOOKEEPER-330.patch, ZOOKEEPER-330.patch
>
>
> ZOOKEEPER-326 made a change to zookeeperservermain.java that broke the starting of zookeeperserver with just the port and datadir.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-330) zookeeper standalone server does
not startup with just a port and datadir.
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-330:
------------------------------------
Status: Patch Available (was: Open)
> zookeeper standalone server does not startup with just a port and datadir.
> --------------------------------------------------------------------------
>
> Key: ZOOKEEPER-330
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-330
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.1.1, 3.2.0
> Reporter: Mahadev konar
> Assignee: Mahadev konar
> Priority: Blocker
> Fix For: 3.1.1, 3.2.0
>
> Attachments: ZOOKEEPER-330.patch
>
>
> ZOOKEEPER-326 made a change to zookeeperservermain.java that broke the starting of zookeeperserver with just the port and datadir.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-330) zookeeper standalone server does
not startup with just a port and datadir.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677687#action_12677687 ]
Hudson commented on ZOOKEEPER-330:
----------------------------------
Integrated in ZooKeeper-trunk #243 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/243/])
. zookeeper standalone server does not startup with just a port and datadir. (chris darroch and mahadev)
> zookeeper standalone server does not startup with just a port and datadir.
> --------------------------------------------------------------------------
>
> Key: ZOOKEEPER-330
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-330
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.1.1, 3.2.0
> Reporter: Mahadev konar
> Assignee: Mahadev konar
> Priority: Blocker
> Fix For: 3.1.1, 3.2.0
>
> Attachments: ZOOKEEPER-330.patch, ZOOKEEPER-330.patch
>
>
> ZOOKEEPER-326 made a change to zookeeperservermain.java that broke the starting of zookeeperserver with just the port and datadir.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-330) zookeeper standalone server does
not startup with just a port and datadir.
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677250#action_12677250 ]
Mahadev konar commented on ZOOKEEPER-330:
-----------------------------------------
+1 for the aptch .... good changes chris...
> zookeeper standalone server does not startup with just a port and datadir.
> --------------------------------------------------------------------------
>
> Key: ZOOKEEPER-330
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-330
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.1.1, 3.2.0
> Reporter: Mahadev konar
> Assignee: Mahadev konar
> Priority: Blocker
> Fix For: 3.1.1, 3.2.0
>
> Attachments: ZOOKEEPER-330.patch, ZOOKEEPER-330.patch
>
>
> ZOOKEEPER-326 made a change to zookeeperservermain.java that broke the starting of zookeeperserver with just the port and datadir.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-330) zookeeper standalone server does
not startup with just a port and datadir.
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-330:
------------------------------------
Attachment: ZOOKEEPER-330.patch
this patch fixes the issue.
ZOOKEEPER-326 made the ZookeeperServerMain args to take just a config file rather than its initial semantics of taking a clientport and datadir.
The ZookeeperServerMain class now takes the same arguments that it did earlier with an additional optional argument of ticktime.
so the command will look like
ZooKeeperServerMain port datadir [ticktime]
ticktime being optional.
If users want to use a config file for a standalone server they can use
QuorumPeerMain configfile
> zookeeper standalone server does not startup with just a port and datadir.
> --------------------------------------------------------------------------
>
> Key: ZOOKEEPER-330
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-330
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.1.1, 3.2.0
> Reporter: Mahadev konar
> Assignee: Mahadev konar
> Priority: Blocker
> Fix For: 3.1.1, 3.2.0
>
> Attachments: ZOOKEEPER-330.patch
>
>
> ZOOKEEPER-326 made a change to zookeeperservermain.java that broke the starting of zookeeperserver with just the port and datadir.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.