[GitHub] [spark] mridulm commented on a diff in pull request #43030: [SPARK-45250][core] Support stage level task resource profile for yarn cluster when dynamic allocation disabled

["mridulm (via GitHub)" <gi...@apache.org>]

mridulm commented on code in PR #43030:
URL: https://github.com/apache/spark/pull/43030#discussion_r1340748033


##########
core/src/main/scala/org/apache/spark/resource/ResourceProfileManager.scala:
##########
@@ -57,6 +57,7 @@ private[spark] class ResourceProfileManager(sparkConf: SparkConf,
   private val isStandaloneOrLocalCluster = master.isDefined && (
       master.get.startsWith("spark://") || master.get.startsWith("local-cluster")
     )
+  private val supportTaskResourceProfile = isStandaloneOrLocalCluster || isYarn

Review Comment:
   We should either inline it, or also check whether DRA is disabled - else the variable is inaccurate.
   
   ```suggestion
     private val supportTaskResourceProfile = isStandaloneOrLocalCluster || (isYarn && !dynamicEnabled)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org