You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/07/07 23:45:32 UTC

[GitHub] [solr] ackepenek opened a new pull request, #934: SOLR-9661 added missing operations[withField,withValue] for expression on stream operations

ackepenek opened a new pull request, #934:
URL: https://github.com/apache/solr/pull/934

   https://issues.apache.org/jira/browse/SOLR-9661
   
   <!--
   _(If you are a project committer then you may remove some/all of the following template.)_
   
   Before creating a pull request, please file an issue in the ASF Jira system for Solr:
   
   * https://issues.apache.org/jira/projects/SOLR
   
   You will need to create an account in Jira in order to create an issue.
   
   The title of the PR should reference the Jira issue number in the form:
   
   * SOLR-####: <short description of problem or changes>
   
   SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
   
   Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
   
   
   # Description
   
   Fixed the `withField` and `withValue` usage problem while executing the stream enabled expression.
   # Solution
   
   Defined the functions for `withField` and `withValue` 
   # Tests
   
   expression (withField and withValue) is tested manually.
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
   - [x] I have created a Jira issue and added the issue ID to my pull request title.
   - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
   - [x] I have developed this patch against the `main` branch.
   - [x] I have run `./gradlew check`.
   - [ ] I have added tests for my changes.
   - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
   
   screenshot about improvement:
   
   ![Screenshot from 2022-07-08 02-29-42](https://user-images.githubusercontent.com/1234305/177888929-8aea2a01-0615-4f8d-906f-b4c10bcd3021.png)
   
   
   ![Screenshot from 2022-07-08 02-29-22](https://user-images.githubusercontent.com/1234305/177888942-a88f4f7d-6df8-49f2-9a1d-a7ea497c6091.png)
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr] epugh commented on pull request #934: SOLR-9661 added missing operations[withField,withValue] for expression on stream operations

Posted by GitBox <gi...@apache.org>.
epugh commented on PR #934:
URL: https://github.com/apache/solr/pull/934#issuecomment-1179617752

   seemed to pass!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr] ackepenek commented on pull request #934: SOLR-9661 added missing operations[withField,withValue] for expression on stream operations

Posted by GitBox <gi...@apache.org>.
ackepenek commented on PR #934:
URL: https://github.com/apache/solr/pull/934#issuecomment-1179255123

   @epugh I fixed the broken unit test. I also thought that I add a few unit tests for expressions but I found some statement inside of [unit tests](https://github.com/apache/solr/blob/main/solr/solrj/src/test/org/apache/solr/client/solrj/io/stream/ops/OperationsTest.java). I think these unit tests  look thats enough. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr] epugh commented on pull request #934: SOLR-9661 added missing operations[withField,withValue] for expression on stream operations

Posted by GitBox <gi...@apache.org>.
epugh commented on PR #934:
URL: https://github.com/apache/solr/pull/934#issuecomment-1179013449

   I tested, and this does now run when you pick the "explanation" option.  I wish we had a unit test...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr] epugh commented on pull request #934: SOLR-9661 added missing operations[withField,withValue] for expression on stream operations

Posted by GitBox <gi...@apache.org>.
epugh commented on PR #934:
URL: https://github.com/apache/solr/pull/934#issuecomment-1179070871

   @ackepenek can you look at why the unit test fails?
   
   ```
   ./gradlew :solr:solrj:test --tests "org.apache.solr.client.solrj.io.TestLang.testLang" -Ptests.jvms=1 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=46056942D2DD7B4A -Ptests.file.encoding=ISO-8859-1
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr] epugh merged pull request #934: SOLR-9661 added missing operations[withField,withValue] for expression on stream operations

Posted by GitBox <gi...@apache.org>.
epugh merged PR #934:
URL: https://github.com/apache/solr/pull/934


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr] ackepenek commented on pull request #934: SOLR-9661 added missing operations[withField,withValue] for expression on stream operations

Posted by GitBox <gi...@apache.org>.
ackepenek commented on PR #934:
URL: https://github.com/apache/solr/pull/934#issuecomment-1179304334

   unittest:`org.apache.solr.client.solrj.impl.CloudSolrClientTest.testPerReplicaStateCollection` is failed but I can not reproduce on my local:
   ![image](https://user-images.githubusercontent.com/1234305/178058766-d091e22f-51b6-45b9-9186-710599ddc0ba.png)
   Maybe it was temporary
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org