[GitHub] [flink-ml] lindong28 commented on a diff in pull request #115: [FLINK-26828] Add flink-ml-examples module

[GitBox <gi...@apache.org>]

lindong28 commented on code in PR #115:
URL: https://github.com/apache/flink-ml/pull/115#discussion_r905811310


##########
flink-ml-examples/src/test/java/org/apache/flink/ml/examples/ExamplesTest.java:
##########
@@ -0,0 +1,129 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.ml.examples;
+
+import org.apache.flink.test.util.AbstractTestBase;
+
+import org.apache.commons.io.output.NullPrintStream;
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
+
+import java.io.File;
+import java.io.IOException;
+import java.io.PrintStream;
+import java.lang.reflect.Method;
+import java.net.URL;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Objects;
+import java.util.concurrent.Callable;
+import java.util.concurrent.ExecutionException;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.Future;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.TimeoutException;
+
+/** Extracts all example classes in this package and tests their main methods. */
+@RunWith(Parameterized.class)
+public class ExamplesTest extends AbstractTestBase {

Review Comment:
   Do we still need this class?



##########
docs/content/docs/try-flink-ml/quick-start.md:
##########
@@ -27,213 +27,64 @@ under the License.
 # Quick Start
 
 This document provides a quick introduction to using Flink ML. Readers of this

Review Comment:
   Is there anyway that users can find this doc by visiting the main README?



##########
docs/content/docs/try-flink-ml/quick-start.md:
##########
@@ -27,213 +27,64 @@ under the License.
 # Quick Start
 
 This document provides a quick introduction to using Flink ML. Readers of this
-document will be guided to create a simple Flink job that trains a Machine
+document will be guided to submit a simple Flink job that trains a Machine
 Learning Model and use it to provide prediction service.
 
-## Maven Setup
+## Prerequisite
 
-In order to use Flink ML in a Maven project, add the following dependencies to
-`pom.xml`.
+Please make sure you have installed Flink 1.15.0 in your local environment and

Review Comment:
   Could we make this README consistent with flink-ml-benchmark/README.md when describing the same thing (e.g. setting up Flink and `$FLINK_HOME`). We can also update flink-ml-benchmark/README.md when needed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org