You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "Joe Bowser (JIRA)" <ji...@apache.org> on 2016/08/02 16:36:21 UTC
[jira] [Comment Edited] (CB-8976) platforms/android/build.gradle
modifies android versionCode
[ https://issues.apache.org/jira/browse/CB-8976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15404333#comment-15404333 ]
Joe Bowser edited comment on CB-8976 at 8/2/16 4:35 PM:
--------------------------------------------------------
[~mikemurko] I completely agree with you, and as of 5.2.0, we stopped doing that for all non-XWalk projects. If I didn't agree with you, I wouldn't have commited the change that removed this stupid behaviour. I've been burned by this behaviour personally, and I really have to stop commenting on this because it's going to very quickly start getting into finger pointing and blaming people, which this tracker isn't supposed to be for.
was (Author: bowserj):
[~mikemurko] I completely agree with you, and as of 5.2.0, we stopped doing that. If I didn't agree with you, I wouldn't have commited the change that removed this stupid behaviour. I've been burned by this behaviour personally, and I really have to stop commenting on this because it's going to very quickly start getting into finger pointing and blaming people, which this tracker isn't supposed to be for.
> platforms/android/build.gradle modifies android versionCode
> -----------------------------------------------------------
>
> Key: CB-8976
> URL: https://issues.apache.org/jira/browse/CB-8976
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
> Environment: Android
> Reporter: zack dykes
> Assignee: Joe Bowser
> Priority: Minor
>
> cordova 5.0.0
> platforms/android/build.gradle modifies android versionCode at ln 178
> as I understand it max size for versionCode is (2^31)-1
> http://stackoverflow.com/a/24246191/126600
> in my config.xml:
> {code}
> android-versionCode="1385039613"
> {code}
> when I run {{cordova build android}}, I get:
> {code}
> FAILURE: Build failed with an exception.
> * Where:
> Build file '/Users/zackd/dev/code/cordova/cordova-ansr-fat-client/ondeviceresearch/platforms/android/build.gradle' line: 178
> * What went wrong:
> A problem occurred evaluating root project 'android'.
> > For input string: "13850396130"
> {code}
> and build.gradle, ln 178
> {code}
> versionCode cdvVersionCode ?: Integer.parseInt("" + privateHelpers.extractIntFromManifest("versionCode") + "0")
> {code}
> looks like this is appending "0" to my versionCode, producing 13850396130 which is larger than max size for android versionCode
> if I mod ln 178 as follows, build succeeds
> {code}
> versionCode cdvVersionCode ?: Integer.parseInt("" + privateHelpers.extractIntFromManifest("versionCode"))
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org