You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/26 17:26:34 UTC

[GitHub] [airflow] potiuk commented on a change in pull request #15534: Make Airflow code Pylint 2.8 compatible

potiuk commented on a change in pull request #15534:
URL: https://github.com/apache/airflow/pull/15534#discussion_r620502100



##########
File path: airflow/providers/apache/beam/hooks/beam.py
##########
@@ -94,6 +94,7 @@ def __init__(
         self.log.info("Running command: %s", " ".join(shlex.quote(c) for c in cmd))
         self.process_line_callback = process_line_callback
         self.job_id: Optional[str] = None
+        # pylint: disable=consider-using-with

Review comment:
       Possibly we can rewrite it, but this can be done separately. I wanted to keep minimal/safe set of changes to make it works without risking backwards compatibility/unforeseen side effects.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org