You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/01/03 06:30:18 UTC

[GitHub] [rocketmq-client-go] xujianhai666 opened a new pull request #355: [ISSUE #354] feat: Support PanicHandler

xujianhai666 opened a new pull request #355: [ISSUE #354] feat: Support PanicHandler
URL: https://github.com/apache/rocketmq-client-go/pull/355
 
 
   
   Closes #354

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq-client-go] codecov-io edited a comment on issue #355: [ISSUE #354] feat: Support PanicHandler

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #355: [ISSUE #354] feat: Support PanicHandler
URL: https://github.com/apache/rocketmq-client-go/pull/355#issuecomment-570478404
 
 
   # [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/355?src=pr&el=h1) Report
   > Merging [#355](https://codecov.io/gh/apache/rocketmq-client-go/pull/355?src=pr&el=desc) into [native](https://codecov.io/gh/apache/rocketmq-client-go/commit/598c979ebd6db2212776e8e38d7f623090360481?src=pr&el=desc) will **decrease** coverage by `<.01%`.
   > The diff coverage is `33.33%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq-client-go/pull/355/graphs/tree.svg?width=650&token=CiV9ofPkG3&height=150&src=pr)](https://codecov.io/gh/apache/rocketmq-client-go/pull/355?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           native     #355      +/-   ##
   ==========================================
   - Coverage   26.28%   26.27%   -0.01%     
   ==========================================
     Files          47       47              
     Lines        5535     5556      +21     
   ==========================================
   + Hits         1455     1460       +5     
   - Misses       3889     3905      +16     
     Partials      191      191
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/355?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [internal/trace.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/355/diff?src=pr&el=tree#diff-aW50ZXJuYWwvdHJhY2UuZ28=) | `30.15% <0%> (-0.99%)` | :arrow_down: |
   | [internal/client.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/355/diff?src=pr&el=tree#diff-aW50ZXJuYWwvY2xpZW50Lmdv) | `0.24% <0%> (ø)` | :arrow_up: |
   | [primitive/base.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/355/diff?src=pr&el=tree#diff-cHJpbWl0aXZlL2Jhc2UuZ28=) | `20% <0%> (-5%)` | :arrow_down: |
   | [producer/producer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/355/diff?src=pr&el=tree#diff-cHJvZHVjZXIvcHJvZHVjZXIuZ28=) | `29.5% <0%> (-0.19%)` | :arrow_down: |
   | [consumer/statistics.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/355/diff?src=pr&el=tree#diff-Y29uc3VtZXIvc3RhdGlzdGljcy5nbw==) | `65.3% <100%> (ø)` | :arrow_up: |
   | [consumer/push\_consumer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/355/diff?src=pr&el=tree#diff-Y29uc3VtZXIvcHVzaF9jb25zdW1lci5nbw==) | `13.44% <37.5%> (+0.13%)` | :arrow_up: |
   | [internal/remote/remote\_client.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/355/diff?src=pr&el=tree#diff-aW50ZXJuYWwvcmVtb3RlL3JlbW90ZV9jbGllbnQuZ28=) | `51.81% <87.5%> (+1.01%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/355?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/355?src=pr&el=footer). Last update [598c979...c581f42](https://codecov.io/gh/apache/rocketmq-client-go/pull/355?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq-client-go] codecov-io edited a comment on issue #355: [ISSUE #354] feat: Support PanicHandler

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #355: [ISSUE #354] feat: Support PanicHandler
URL: https://github.com/apache/rocketmq-client-go/pull/355#issuecomment-570478404
 
 
   # [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/355?src=pr&el=h1) Report
   > Merging [#355](https://codecov.io/gh/apache/rocketmq-client-go/pull/355?src=pr&el=desc) into [native](https://codecov.io/gh/apache/rocketmq-client-go/commit/598c979ebd6db2212776e8e38d7f623090360481?src=pr&el=desc) will **increase** coverage by `<.01%`.
   > The diff coverage is `36.84%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq-client-go/pull/355/graphs/tree.svg?width=650&token=CiV9ofPkG3&height=150&src=pr)](https://codecov.io/gh/apache/rocketmq-client-go/pull/355?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           native     #355      +/-   ##
   ==========================================
   + Coverage   26.28%   26.29%   +<.01%     
   ==========================================
     Files          47       47              
     Lines        5535     5556      +21     
   ==========================================
   + Hits         1455     1461       +6     
   - Misses       3889     3904      +15     
     Partials      191      191
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/355?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [internal/trace.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/355/diff?src=pr&el=tree#diff-aW50ZXJuYWwvdHJhY2UuZ28=) | `30.15% <0%> (-0.99%)` | :arrow_down: |
   | [internal/client.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/355/diff?src=pr&el=tree#diff-aW50ZXJuYWwvY2xpZW50Lmdv) | `0.24% <0%> (ø)` | :arrow_up: |
   | [primitive/base.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/355/diff?src=pr&el=tree#diff-cHJpbWl0aXZlL2Jhc2UuZ28=) | `20% <0%> (-5%)` | :arrow_down: |
   | [producer/producer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/355/diff?src=pr&el=tree#diff-cHJvZHVjZXIvcHJvZHVjZXIuZ28=) | `29.5% <0%> (-0.19%)` | :arrow_down: |
   | [consumer/statistics.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/355/diff?src=pr&el=tree#diff-Y29uc3VtZXIvc3RhdGlzdGljcy5nbw==) | `65.3% <100%> (ø)` | :arrow_up: |
   | [consumer/push\_consumer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/355/diff?src=pr&el=tree#diff-Y29uc3VtZXIvcHVzaF9jb25zdW1lci5nbw==) | `13.44% <37.5%> (+0.13%)` | :arrow_up: |
   | [internal/remote/remote\_client.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/355/diff?src=pr&el=tree#diff-aW50ZXJuYWwvcmVtb3RlL3JlbW90ZV9jbGllbnQuZ28=) | `52.33% <70.58%> (+1.53%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/355?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/355?src=pr&el=footer). Last update [598c979...769d308](https://codecov.io/gh/apache/rocketmq-client-go/pull/355?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq-client-go] wenfengwang merged pull request #355: [ISSUE #354] feat: Support PanicHandler

Posted by GitBox <gi...@apache.org>.
wenfengwang merged pull request #355: [ISSUE #354] feat: Support PanicHandler
URL: https://github.com/apache/rocketmq-client-go/pull/355
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq-client-go] wenfengwang commented on issue #355: [ISSUE #354] feat: Support PanicHandler

Posted by GitBox <gi...@apache.org>.
wenfengwang commented on issue #355: [ISSUE #354] feat: Support PanicHandler
URL: https://github.com/apache/rocketmq-client-go/pull/355#issuecomment-570975735
 
 
   The panic handler not needed in the client, because the logic of it should be controlled, any unexpected panic(error) should be fixed. if one has trouble with panic, there should add a panic handler by themself

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq-client-go] codecov-io edited a comment on issue #355: [ISSUE #354] feat: Support PanicHandler

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #355: [ISSUE #354] feat: Support PanicHandler
URL: https://github.com/apache/rocketmq-client-go/pull/355#issuecomment-570478404
 
 
   # [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/355?src=pr&el=h1) Report
   > Merging [#355](https://codecov.io/gh/apache/rocketmq-client-go/pull/355?src=pr&el=desc) into [native](https://codecov.io/gh/apache/rocketmq-client-go/commit/598c979ebd6db2212776e8e38d7f623090360481?src=pr&el=desc) will **decrease** coverage by `<.01%`.
   > The diff coverage is `33.33%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq-client-go/pull/355/graphs/tree.svg?width=650&token=CiV9ofPkG3&height=150&src=pr)](https://codecov.io/gh/apache/rocketmq-client-go/pull/355?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           native     #355      +/-   ##
   ==========================================
   - Coverage   26.28%   26.27%   -0.01%     
   ==========================================
     Files          47       47              
     Lines        5535     5556      +21     
   ==========================================
   + Hits         1455     1460       +5     
   - Misses       3889     3905      +16     
     Partials      191      191
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/355?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [internal/trace.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/355/diff?src=pr&el=tree#diff-aW50ZXJuYWwvdHJhY2UuZ28=) | `30.15% <0%> (-0.99%)` | :arrow_down: |
   | [internal/client.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/355/diff?src=pr&el=tree#diff-aW50ZXJuYWwvY2xpZW50Lmdv) | `0.24% <0%> (ø)` | :arrow_up: |
   | [primitive/base.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/355/diff?src=pr&el=tree#diff-cHJpbWl0aXZlL2Jhc2UuZ28=) | `20% <0%> (-5%)` | :arrow_down: |
   | [producer/producer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/355/diff?src=pr&el=tree#diff-cHJvZHVjZXIvcHJvZHVjZXIuZ28=) | `29.5% <0%> (-0.19%)` | :arrow_down: |
   | [consumer/statistics.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/355/diff?src=pr&el=tree#diff-Y29uc3VtZXIvc3RhdGlzdGljcy5nbw==) | `65.3% <100%> (ø)` | :arrow_up: |
   | [consumer/push\_consumer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/355/diff?src=pr&el=tree#diff-Y29uc3VtZXIvcHVzaF9jb25zdW1lci5nbw==) | `13.44% <37.5%> (+0.13%)` | :arrow_up: |
   | [internal/remote/remote\_client.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/355/diff?src=pr&el=tree#diff-aW50ZXJuYWwvcmVtb3RlL3JlbW90ZV9jbGllbnQuZ28=) | `51.81% <87.5%> (+1.01%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/355?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/355?src=pr&el=footer). Last update [598c979...c581f42](https://codecov.io/gh/apache/rocketmq-client-go/pull/355?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq-client-go] codecov-io commented on issue #355: [ISSUE #354] feat: Support PanicHandler

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #355: [ISSUE #354] feat: Support PanicHandler
URL: https://github.com/apache/rocketmq-client-go/pull/355#issuecomment-570478404
 
 
   # [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/355?src=pr&el=h1) Report
   > Merging [#355](https://codecov.io/gh/apache/rocketmq-client-go/pull/355?src=pr&el=desc) into [native](https://codecov.io/gh/apache/rocketmq-client-go/commit/598c979ebd6db2212776e8e38d7f623090360481?src=pr&el=desc) will **increase** coverage by `<.01%`.
   > The diff coverage is `36.84%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq-client-go/pull/355/graphs/tree.svg?width=650&token=CiV9ofPkG3&height=150&src=pr)](https://codecov.io/gh/apache/rocketmq-client-go/pull/355?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           native     #355      +/-   ##
   ==========================================
   + Coverage   26.28%   26.29%   +<.01%     
   ==========================================
     Files          47       47              
     Lines        5535     5556      +21     
   ==========================================
   + Hits         1455     1461       +6     
   - Misses       3889     3904      +15     
     Partials      191      191
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/355?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [internal/trace.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/355/diff?src=pr&el=tree#diff-aW50ZXJuYWwvdHJhY2UuZ28=) | `30.15% <0%> (-0.99%)` | :arrow_down: |
   | [internal/client.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/355/diff?src=pr&el=tree#diff-aW50ZXJuYWwvY2xpZW50Lmdv) | `0.24% <0%> (ø)` | :arrow_up: |
   | [primitive/base.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/355/diff?src=pr&el=tree#diff-cHJpbWl0aXZlL2Jhc2UuZ28=) | `20% <0%> (-5%)` | :arrow_down: |
   | [producer/producer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/355/diff?src=pr&el=tree#diff-cHJvZHVjZXIvcHJvZHVjZXIuZ28=) | `29.5% <0%> (-0.19%)` | :arrow_down: |
   | [consumer/statistics.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/355/diff?src=pr&el=tree#diff-Y29uc3VtZXIvc3RhdGlzdGljcy5nbw==) | `65.3% <100%> (ø)` | :arrow_up: |
   | [consumer/push\_consumer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/355/diff?src=pr&el=tree#diff-Y29uc3VtZXIvcHVzaF9jb25zdW1lci5nbw==) | `13.44% <37.5%> (+0.13%)` | :arrow_up: |
   | [internal/remote/remote\_client.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/355/diff?src=pr&el=tree#diff-aW50ZXJuYWwvcmVtb3RlL3JlbW90ZV9jbGllbnQuZ28=) | `52.33% <70.58%> (+1.53%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/355?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/355?src=pr&el=footer). Last update [598c979...769d308](https://codecov.io/gh/apache/rocketmq-client-go/pull/355?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq-client-go] codecov-io edited a comment on issue #355: [ISSUE #354] feat: Support PanicHandler

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #355: [ISSUE #354] feat: Support PanicHandler
URL: https://github.com/apache/rocketmq-client-go/pull/355#issuecomment-570478404
 
 
   # [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/355?src=pr&el=h1) Report
   > Merging [#355](https://codecov.io/gh/apache/rocketmq-client-go/pull/355?src=pr&el=desc) into [native](https://codecov.io/gh/apache/rocketmq-client-go/commit/2ace48afd7c054fa6231e28407f7e40f76c84ad6?src=pr&el=desc) will **increase** coverage by `0.05%`.
   > The diff coverage is `34.04%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq-client-go/pull/355/graphs/tree.svg?width=650&token=CiV9ofPkG3&height=150&src=pr)](https://codecov.io/gh/apache/rocketmq-client-go/pull/355?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           native     #355      +/-   ##
   ==========================================
   + Coverage   25.31%   25.37%   +0.05%     
   ==========================================
     Files          47       47              
     Lines        5459     5470      +11     
   ==========================================
   + Hits         1382     1388       +6     
   - Misses       3887     3892       +5     
     Partials      190      190
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/355?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [internal/trace.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/355/diff?src=pr&el=tree#diff-aW50ZXJuYWwvdHJhY2UuZ28=) | `30.03% <0%> (-0.99%)` | :arrow_down: |
   | [internal/client.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/355/diff?src=pr&el=tree#diff-aW50ZXJuYWwvY2xpZW50Lmdv) | `0.24% <0%> (ø)` | :arrow_up: |
   | [primitive/base.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/355/diff?src=pr&el=tree#diff-cHJpbWl0aXZlL2Jhc2UuZ28=) | `20% <0%> (-5%)` | :arrow_down: |
   | [producer/producer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/355/diff?src=pr&el=tree#diff-cHJvZHVjZXIvcHJvZHVjZXIuZ28=) | `29.84% <0%> (-0.07%)` | :arrow_down: |
   | [consumer/statistics.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/355/diff?src=pr&el=tree#diff-Y29uc3VtZXIvc3RhdGlzdGljcy5nbw==) | `63.66% <100%> (ø)` | :arrow_up: |
   | [consumer/push\_consumer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/355/diff?src=pr&el=tree#diff-Y29uc3VtZXIvcHVzaF9jb25zdW1lci5nbw==) | `13.42% <42.85%> (+0.11%)` | :arrow_up: |
   | [internal/remote/remote\_client.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/355/diff?src=pr&el=tree#diff-aW50ZXJuYWwvcmVtb3RlL3JlbW90ZV9jbGllbnQuZ28=) | `48.69% <87.5%> (+1.09%)` | :arrow_up: |
   | [internal/mock\_client.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/355/diff?src=pr&el=tree#diff-aW50ZXJuYWwvbW9ja19jbGllbnQuZ28=) | `0% <0%> (ø)` | :arrow_up: |
   | [internal/validators.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/355/diff?src=pr&el=tree#diff-aW50ZXJuYWwvdmFsaWRhdG9ycy5nbw==) | `0% <0%> (ø)` | :arrow_up: |
   | ... and [3 more](https://codecov.io/gh/apache/rocketmq-client-go/pull/355/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/355?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/355?src=pr&el=footer). Last update [2ace48a...d030a37](https://codecov.io/gh/apache/rocketmq-client-go/pull/355?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq-client-go] codecov-io edited a comment on issue #355: [ISSUE #354] feat: Support PanicHandler

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #355: [ISSUE #354] feat: Support PanicHandler
URL: https://github.com/apache/rocketmq-client-go/pull/355#issuecomment-570478404
 
 
   # [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/355?src=pr&el=h1) Report
   > Merging [#355](https://codecov.io/gh/apache/rocketmq-client-go/pull/355?src=pr&el=desc) into [native](https://codecov.io/gh/apache/rocketmq-client-go/commit/33798bc30375afecaf1605cfdd8efee9527fb5f4?src=pr&el=desc) will **decrease** coverage by `<.01%`.
   > The diff coverage is `34.04%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq-client-go/pull/355/graphs/tree.svg?width=650&token=CiV9ofPkG3&height=150&src=pr)](https://codecov.io/gh/apache/rocketmq-client-go/pull/355?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           native     #355      +/-   ##
   ==========================================
   - Coverage   25.38%   25.37%   -0.01%     
   ==========================================
     Files          47       47              
     Lines        5449     5470      +21     
   ==========================================
   + Hits         1383     1388       +5     
   - Misses       3876     3892      +16     
     Partials      190      190
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/355?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [internal/client.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/355/diff?src=pr&el=tree#diff-aW50ZXJuYWwvY2xpZW50Lmdv) | `0.24% <0%> (ø)` | :arrow_up: |
   | [internal/trace.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/355/diff?src=pr&el=tree#diff-aW50ZXJuYWwvdHJhY2UuZ28=) | `30.03% <0%> (-0.99%)` | :arrow_down: |
   | [primitive/base.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/355/diff?src=pr&el=tree#diff-cHJpbWl0aXZlL2Jhc2UuZ28=) | `20% <0%> (-5%)` | :arrow_down: |
   | [producer/producer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/355/diff?src=pr&el=tree#diff-cHJvZHVjZXIvcHJvZHVjZXIuZ28=) | `29.84% <0%> (-0.19%)` | :arrow_down: |
   | [consumer/statistics.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/355/diff?src=pr&el=tree#diff-Y29uc3VtZXIvc3RhdGlzdGljcy5nbw==) | `63.66% <100%> (ø)` | :arrow_up: |
   | [consumer/push\_consumer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/355/diff?src=pr&el=tree#diff-Y29uc3VtZXIvcHVzaF9jb25zdW1lci5nbw==) | `13.42% <42.85%> (+0.13%)` | :arrow_up: |
   | [internal/remote/remote\_client.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/355/diff?src=pr&el=tree#diff-aW50ZXJuYWwvcmVtb3RlL3JlbW90ZV9jbGllbnQuZ28=) | `48.69% <87.5%> (+1.09%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/355?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/355?src=pr&el=footer). Last update [33798bc...bd57dd5](https://codecov.io/gh/apache/rocketmq-client-go/pull/355?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services