You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Hoss Man (JIRA)" <ji...@apache.org> on 2012/06/22 00:14:42 UTC
[jira] [Created] (SOLR-3569) distributed debug is empty when no
match to query
Hoss Man created SOLR-3569:
------------------------------
Summary: distributed debug is empty when no match to query
Key: SOLR-3569
URL: https://issues.apache.org/jira/browse/SOLR-3569
Project: Solr
Issue Type: Bug
Reporter: Hoss Man
Priority: Minor
If a query matches 0 documents, the "debug" information for a distributed query will be empty - ie: no information on timing, or (most importantly for many people) query parsing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-3569) distributed debug is empty when no
match to query
Posted by "David Bowen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Bowen updated SOLR-3569:
------------------------------
Attachment: SOLR-3569.patch
I've been annoyed by this too.
Here is a patch which adds query-debug info when there are no results from the shards.
> distributed debug is empty when no match to query
> -------------------------------------------------
>
> Key: SOLR-3569
> URL: https://issues.apache.org/jira/browse/SOLR-3569
> Project: Solr
> Issue Type: Bug
> Reporter: Hoss Man
> Priority: Minor
> Attachments: SOLR-3569.patch
>
>
> If a query matches 0 documents, the "debug" information for a distributed query will be empty - ie: no information on timing, or (most importantly for many people) query parsing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-3569) distributed debug is empty when no
match to query
Posted by "Hoss Man (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hoss Man updated SOLR-3569:
---------------------------
Attachment: SOLR-3569.patch
My suggestion addressed the situation of trying to decalre the fieldType as multiValued, but did nothing to address fields & dynamic fields that were explicitly declared multiValued.
So in the attached patch i introduce a new method into the FieldType api called "checkSchemaField" which the SchemaField constructor uses to let the FieldType check the instance for errors that violate any invariants about hte field type. the default impl is a NOOP and CurrencyField overrides this.
Would like someone to sanity check that this approach is a good idea (seems like it would definitely have other uses moving forward) otherwise i think it's feasible solution to the currency multivalued problem and we should get it in for 4.0
> distributed debug is empty when no match to query
> -------------------------------------------------
>
> Key: SOLR-3569
> URL: https://issues.apache.org/jira/browse/SOLR-3569
> Project: Solr
> Issue Type: Bug
> Reporter: Hoss Man
> Priority: Minor
> Attachments: SOLR-3569.patch, SOLR-3569.patch
>
>
> If a query matches 0 documents, the "debug" information for a distributed query will be empty - ie: no information on timing, or (most importantly for many people) query parsing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3569) distributed debug is empty when no
match to query
Posted by "David Bowen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13451466#comment-13451466 ]
David Bowen commented on SOLR-3569:
-----------------------------------
With the patch, the debug output in the distributed case now looks like this:
[http://localhost:8983/solr/select?q=foo_s:basdfasd&debugQuery=true&wt=json&indent=true&shards=localhost:8983/solr]
{noformat}
{
"responseHeader":{
"status":0,
"QTime":5,
"params":{
"debugQuery":"true",
"shards":"localhost:8983/solr",
"indent":"true",
"wt":"json",
"q":"foo_s:basdfasd"}},
"response":{"numFound":0,"start":0,"maxScore":0.0,"docs":[]
},
"debug":{
"rawquerystring":"foo_s:basdfasd",
"querystring":"foo_s:basdfasd",
"parsedquery":"foo_s:basdfasd",
"parsedquery_toString":"foo_s:basdfasd",
"QParser":"LuceneQParser",
"explain":{}}}
{noformat}
so it is missing any timing information, but that does not seem to be useful anyway in the case of no results.
> distributed debug is empty when no match to query
> -------------------------------------------------
>
> Key: SOLR-3569
> URL: https://issues.apache.org/jira/browse/SOLR-3569
> Project: Solr
> Issue Type: Bug
> Reporter: Hoss Man
> Priority: Minor
> Attachments: SOLR-3569.patch
>
>
> If a query matches 0 documents, the "debug" information for a distributed query will be empty - ie: no information on timing, or (most importantly for many people) query parsing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-3569) distributed debug is empty when no
match to query
Posted by "Hoss Man (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hoss Man updated SOLR-3569:
---------------------------
Attachment: (was: SOLR-3569.patch)
> distributed debug is empty when no match to query
> -------------------------------------------------
>
> Key: SOLR-3569
> URL: https://issues.apache.org/jira/browse/SOLR-3569
> Project: Solr
> Issue Type: Bug
> Reporter: Hoss Man
> Priority: Minor
> Attachments: SOLR-3569.patch
>
>
> If a query matches 0 documents, the "debug" information for a distributed query will be empty - ie: no information on timing, or (most importantly for many people) query parsing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3569) distributed debug is empty when no
match to query
Posted by "Hoss Man (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398926#comment-13398926 ]
Hoss Man commented on SOLR-3569:
--------------------------------
discovered this while helping someone on IRC. trivial to reproduce using the example, compare...
http://localhost:8983/solr/select?q=foo_s:basdfasd&debugQuery=true&wt=json&indent=true&shards=localhost:8983/solr
{noformat}
{
"responseHeader":{
"status":0,
"QTime":11,
"params":{
"debugQuery":"true",
"shards":"localhost:8983/solr",
"indent":"true",
"wt":"json",
"q":"foo_s:basdfasd"}},
"response":{"numFound":0,"start":0,"docs":[]
},
"debug":{
"explain":{}}}
{noformat}
...with the non-distrib version...
http://localhost:8983/solr/select?q=foo_s:basdfasd&debugQuery=true&wt=json&indent=true
{noformat}
{
"responseHeader":{
"status":0,
"QTime":0,
"params":{
"debugQuery":"true",
"indent":"true",
"wt":"json",
"q":"foo_s:basdfasd"}},
"response":{"numFound":0,"start":0,"docs":[]
},
"debug":{
"rawquerystring":"foo_s:basdfasd",
"querystring":"foo_s:basdfasd",
"parsedquery":"foo_s:basdfasd",
"parsedquery_toString":"foo_s:basdfasd",
"explain":{},
"QParser":"LuceneQParser",
"timing":{
"time":0.0,
"prepare":{
"time":0.0,
"org.apache.solr.handler.component.QueryComponent":{
"time":0.0},
"org.apache.solr.handler.component.FacetComponent":{
"time":0.0},
"org.apache.solr.handler.component.MoreLikeThisComponent":{
"time":0.0},
"org.apache.solr.handler.component.HighlightComponent":{
"time":0.0},
"org.apache.solr.handler.component.StatsComponent":{
"time":0.0},
"org.apache.solr.handler.component.DebugComponent":{
"time":0.0}},
"process":{
"time":0.0,
"org.apache.solr.handler.component.QueryComponent":{
"time":0.0},
"org.apache.solr.handler.component.FacetComponent":{
"time":0.0},
"org.apache.solr.handler.component.MoreLikeThisComponent":{
"time":0.0},
"org.apache.solr.handler.component.HighlightComponent":{
"time":0.0},
"org.apache.solr.handler.component.StatsComponent":{
"time":0.0},
"org.apache.solr.handler.component.DebugComponent":{
"time":0.0}}}}}
{noformat}
> distributed debug is empty when no match to query
> -------------------------------------------------
>
> Key: SOLR-3569
> URL: https://issues.apache.org/jira/browse/SOLR-3569
> Project: Solr
> Issue Type: Bug
> Reporter: Hoss Man
> Priority: Minor
>
> If a query matches 0 documents, the "debug" information for a distributed query will be empty - ie: no information on timing, or (most importantly for many people) query parsing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (SOLR-3569) distributed debug is empty when no
match to query
Posted by "Hoss Man (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hoss Man resolved SOLR-3569.
----------------------------
Resolution: Fixed
Fix Version/s: 4.0
Assignee: Hoss Man
David: thanks for the patch!
Definitely better then the current situation.
Committed revision 1384597.
Committed revision 1384599. - 4x
> distributed debug is empty when no match to query
> -------------------------------------------------
>
> Key: SOLR-3569
> URL: https://issues.apache.org/jira/browse/SOLR-3569
> Project: Solr
> Issue Type: Bug
> Reporter: Hoss Man
> Assignee: Hoss Man
> Priority: Minor
> Fix For: 4.0
>
> Attachments: SOLR-3569.patch
>
>
> If a query matches 0 documents, the "debug" information for a distributed query will be empty - ie: no information on timing, or (most importantly for many people) query parsing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Comment Edited] (SOLR-3569) distributed debug is empty when
no match to query
Posted by "Hoss Man (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13453506#comment-13453506 ]
Hoss Man edited comment on SOLR-3569 at 9/12/12 9:44 AM:
---------------------------------------------------------
*DELETED* -- wrong issue
was (Author: hossman):
My suggestion addressed the situation of trying to decalre the fieldType as multiValued, but did nothing to address fields & dynamic fields that were explicitly declared multiValued.
So in the attached patch i introduce a new method into the FieldType api called "checkSchemaField" which the SchemaField constructor uses to let the FieldType check the instance for errors that violate any invariants about hte field type. the default impl is a NOOP and CurrencyField overrides this.
Would like someone to sanity check that this approach is a good idea (seems like it would definitely have other uses moving forward) otherwise i think it's feasible solution to the currency multivalued problem and we should get it in for 4.0
> distributed debug is empty when no match to query
> -------------------------------------------------
>
> Key: SOLR-3569
> URL: https://issues.apache.org/jira/browse/SOLR-3569
> Project: Solr
> Issue Type: Bug
> Reporter: Hoss Man
> Priority: Minor
> Attachments: SOLR-3569.patch, SOLR-3569.patch
>
>
> If a query matches 0 documents, the "debug" information for a distributed query will be empty - ie: no information on timing, or (most importantly for many people) query parsing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org