You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2024/05/01 07:21:00 UTC
[jira] [Commented] (MRESOLVER-554) Support configuration of upload/download threads individually
[ https://issues.apache.org/jira/browse/MRESOLVER-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842564#comment-17842564 ]
ASF GitHub Bot commented on MRESOLVER-554:
------------------------------------------
michael-o commented on code in PR #489:
URL: https://github.com/apache/maven-resolver/pull/489#discussion_r1585969952
##########
maven-resolver-connector-basic/src/main/java/org/eclipse/aether/connector/basic/BasicRepositoryConnector.java:
##########
@@ -97,15 +100,17 @@ final class BasicRepositoryConnector implements RepositoryConnector {
private final ChecksumPolicyProvider checksumPolicyProvider;
- private final int maxThreads;
+ private final int maxDownstreamThreads;
+
+ private final int maxUpstreamThreads;
private final boolean smartChecksums;
private final boolean parallelPut;
private final boolean persistedChecksums;
- private Executor executor;
+ private final ConcurrentHashMap<Boolean, Executor> executors;
Review Comment:
Just a remark. An Enum would read better than just a boolean...
> Support configuration of upload/download threads individually
> -------------------------------------------------------------
>
> Key: MRESOLVER-554
> URL: https://issues.apache.org/jira/browse/MRESOLVER-554
> Project: Maven Resolver
> Issue Type: Improvement
> Components: Resolver
> Reporter: Matt Nelson
> Assignee: Tamas Cservenak
> Priority: Major
> Fix For: 2.0.0, 2.0.0-beta-1
>
>
> Parallel deploys were introduced in MRESOLVER-32. The thread pool configuration is shared for uploads and downloads. It has been observed in our environment that uploads frequently error out when attempting to upload with the default thread pool size(5), but conversely we don't see the same errors for downloads.
> The proposal is to support configuration of upload/download thread pools individually.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)