You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by xi...@apache.org on 2017/09/12 21:19:45 UTC

[04/26] samza git commit: SAMZA-1389: Fix ZkProcessorLatch await(timeout, TimeUnit) api.

SAMZA-1389: Fix ZkProcessorLatch await(timeout, TimeUnit) api.

Use passed in timeUnit value for zkClient.waitUnitExists method rather than hardcoding with  `TimeUnit.MILLISECONDS`.

Author: Shanthoosh Venkataraman <sv...@linkedin.com>

Reviewers: Boris Shkolnik <bo...@apache.org>,Fred Ji <fr...@yahoo.com>,Jagadish <jv...@linkedin.com>

Closes #268 from shanthoosh/fix_zklatch_impl


Project: http://git-wip-us.apache.org/repos/asf/samza/repo
Commit: http://git-wip-us.apache.org/repos/asf/samza/commit/46b3601f
Tree: http://git-wip-us.apache.org/repos/asf/samza/tree/46b3601f
Diff: http://git-wip-us.apache.org/repos/asf/samza/diff/46b3601f

Branch: refs/heads/0.14.0
Commit: 46b3601f1a3bbe792338f160f8283ff32b65547a
Parents: 06702af
Author: Shanthoosh Venkataraman <sv...@linkedin.com>
Authored: Fri Aug 11 11:51:32 2017 -0700
Committer: Jacob Maes <jm...@linkedin.com>
Committed: Fri Aug 11 11:51:32 2017 -0700

----------------------------------------------------------------------
 .../src/main/java/org/apache/samza/zk/ZkProcessorLatch.java      | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/samza/blob/46b3601f/samza-core/src/main/java/org/apache/samza/zk/ZkProcessorLatch.java
----------------------------------------------------------------------
diff --git a/samza-core/src/main/java/org/apache/samza/zk/ZkProcessorLatch.java b/samza-core/src/main/java/org/apache/samza/zk/ZkProcessorLatch.java
index ddc8976..decdd7d 100644
--- a/samza-core/src/main/java/org/apache/samza/zk/ZkProcessorLatch.java
+++ b/samza-core/src/main/java/org/apache/samza/zk/ZkProcessorLatch.java
@@ -53,8 +53,8 @@ public class ZkProcessorLatch implements Latch {
   }
 
   @Override
-  public void await(long timeout, TimeUnit tu) {
-    zkUtils.getZkClient().waitUntilExists(targetPath, TimeUnit.MILLISECONDS, timeout);
+  public void await(long timeout, TimeUnit timeUnit) {
+    zkUtils.getZkClient().waitUntilExists(targetPath, timeUnit, timeout);
   }
 
   @Override