You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/03/25 19:37:24 UTC
[GitHub] [beam] rohdesamuel opened a new pull request #11227: [BEAM-9601]
Skip the streaming wordcount test because it uses a Python3.5.3+ feature
rohdesamuel opened a new pull request #11227: [BEAM-9601] Skip the streaming wordcount test because it uses a Python3.5.3+ feature
URL: https://github.com/apache/beam/pull/11227
Change-Id: I9caaf395fd0fc58565e54a8458e8289af761815f
The InteractiveRunner requires Python3.5.3+. We have a pattern in which we disable the tests that fail on Python2.7.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/)
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/)
XLang | --- | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/)
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] pabloem commented on issue #11227: [BEAM-9601] Skip the
streaming wordcount test because it uses a Python3.5.3+ feature
Posted by GitBox <gi...@apache.org>.
pabloem commented on issue #11227: [BEAM-9601] Skip the streaming wordcount test because it uses a Python3.5.3+ feature
URL: https://github.com/apache/beam/pull/11227#issuecomment-604099693
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] rohdesamuel commented on a change in pull request #11227:
[BEAM-9601] Skip the streaming wordcount test because it uses a
Python3.5.3+ feature
Posted by GitBox <gi...@apache.org>.
rohdesamuel commented on a change in pull request #11227: [BEAM-9601] Skip the streaming wordcount test because it uses a Python3.5.3+ feature
URL: https://github.com/apache/beam/pull/11227#discussion_r398175950
##########
File path: sdks/python/apache_beam/runners/interactive/interactive_runner_test.py
##########
@@ -150,9 +151,10 @@ def process(self, element):
]
self.assertEqual(actual_reified, expected_reified)
+ @unittest.skipIf(
+ sys.version_info < (3, 6),
+ 'InteractiveRunner has a minimum Python version of 3.5.3.')
Review comment:
Yeah, sounds good. Testing it on 3.5.4 led to some elements being in non-deterministic order, so I fixed up the Dataframe equality logic to also do a sort. Though interestingly enough this passes on later version of Python. This is probably because the dict ordering respects insertion ordering on later version, 3.6+ if I'm not mistaken.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] pabloem commented on issue #11227: [BEAM-9601] Skip the
streaming wordcount test because it uses a Python3.5.3+ feature
Posted by GitBox <gi...@apache.org>.
pabloem commented on issue #11227: [BEAM-9601] Skip the streaming wordcount test because it uses a Python3.5.3+ feature
URL: https://github.com/apache/beam/pull/11227#issuecomment-604099816
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] pabloem commented on issue #11227: [BEAM-9601] Skip the
streaming wordcount test because it uses a Python3.5.3+ feature
Posted by GitBox <gi...@apache.org>.
pabloem commented on issue #11227: [BEAM-9601] Skip the streaming wordcount test because it uses a Python3.5.3+ feature
URL: https://github.com/apache/beam/pull/11227#issuecomment-604100957
Run Python PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] pabloem merged pull request #11227: [BEAM-9601] Skip the
streaming wordcount test because it uses a Python3.5.3+ feature
Posted by GitBox <gi...@apache.org>.
pabloem merged pull request #11227: [BEAM-9601] Skip the streaming wordcount test because it uses a Python3.5.3+ feature
URL: https://github.com/apache/beam/pull/11227
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] pabloem commented on issue #11227: [BEAM-9601] Skip the
streaming wordcount test because it uses a Python3.5.3+ feature
Posted by GitBox <gi...@apache.org>.
pabloem commented on issue #11227: [BEAM-9601] Skip the streaming wordcount test because it uses a Python3.5.3+ feature
URL: https://github.com/apache/beam/pull/11227#issuecomment-604099649
thanks Sam!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] pabloem commented on issue #11227: [BEAM-9601] Skip the
streaming wordcount test because it uses a Python3.5.3+ feature
Posted by GitBox <gi...@apache.org>.
pabloem commented on issue #11227: [BEAM-9601] Skip the streaming wordcount test because it uses a Python3.5.3+ feature
URL: https://github.com/apache/beam/pull/11227#issuecomment-604045227
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] pabloem commented on a change in pull request #11227:
[BEAM-9601] Skip the streaming wordcount test because it uses a
Python3.5.3+ feature
Posted by GitBox <gi...@apache.org>.
pabloem commented on a change in pull request #11227: [BEAM-9601] Skip the streaming wordcount test because it uses a Python3.5.3+ feature
URL: https://github.com/apache/beam/pull/11227#discussion_r398120887
##########
File path: sdks/python/apache_beam/runners/interactive/interactive_runner_test.py
##########
@@ -150,9 +151,10 @@ def process(self, element):
]
self.assertEqual(actual_reified, expected_reified)
+ @unittest.skipIf(
+ sys.version_info < (3, 6),
+ 'InteractiveRunner has a minimum Python version of 3.5.3.')
Review comment:
should we skip if sys.version_info < 3,5,3? so we'll test on 3.5 if it's the right subversion?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services