[GitHub] [camel-k] phantomjinx commented on a diff in pull request #3716: e2e: test fixes and bug fixes from test runs

[GitBox <gi...@apache.org>]

phantomjinx commented on code in PR #3716:
URL: https://github.com/apache/camel-k/pull/3716#discussion_r988849151


##########
e2e/namespace/install/cli/run_test.go:
##########
@@ -36,117 +37,161 @@ import (
 	v1 "github.com/apache/camel-k/pkg/apis/camel/v1"
 )
 
-func TestKamelCLIRun(t *testing.T) {
+var sampleJar = "https://raw.githubusercontent.com/apache/camel-k/main/e2e/global/common/traits/files/jvm/sample-1.0.jar"
+
+func operatorID(ns string) string {
+	return fmt.Sprintf("camel-k-%s", ns)
+}
+
+func installWithID(ns string) {
+	Expect(KamelInstallWithID(operatorID(ns), ns).Execute()).To(Succeed())
+	Eventually(OperatorPod(ns)).ShouldNot(BeNil())
+	Eventually(PlatformPhase(ns), TestTimeoutLong).Should(Equal(v1.IntegrationPlatformPhaseReady))
+}
+
+func TestKamelCLIRunGitHubExampleJava(t *testing.T) {

Review Comment:
   Looking at the test times between 2 test runs, I can see the time differential for both `TestKamelCLIRun` and `TestRunConfig` is large. That being the case, converting the tests is not an ideal solution, despite improvements in reliability. So, I'll modify this back and relook at `TestRunConfig` (think the `kamel delete....` might have to be improved to remove some test contamination).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org