You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@streams.apache.org by steveblackmon <gi...@git.apache.org> on 2015/06/22 14:16:48 UTC
[GitHub] incubator-streams pull request: resolves STREAMS-342
GitHub user steveblackmon opened a pull request:
https://github.com/apache/incubator-streams/pull/234
resolves STREAMS-342
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/steveblackmon/incubator-streams STREAMS-342
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-streams/pull/234.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #234
----
commit 766a3cb01e2f9b1f28a755fc0724f03425870fe9
Author: Steve Blackmon (@steveblackmon) <sb...@apache.org>
Date: 2015-06-22T12:14:31Z
resolves STREAMS-342
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: resolves STREAMS-342
Posted by steveblackmon <gi...@git.apache.org>.
Github user steveblackmon commented on the pull request:
https://github.com/apache/incubator-streams/pull/234#issuecomment-114149439
Travis is failing because streams-project is depending on a snapshot of streams-master that isn't in the apache repo. This will pass in jenkins.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: resolves STREAMS-342
Posted by steveblackmon <gi...@git.apache.org>.
Github user steveblackmon commented on the pull request:
https://github.com/apache/incubator-streams/pull/234#issuecomment-114155255
edited for readability
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: resolves STREAMS-342
Posted by eponvert <gi...@git.apache.org>.
Github user eponvert commented on a diff in the pull request:
https://github.com/apache/incubator-streams/pull/234#discussion_r32946082
--- Diff: streams-contrib/streams-persist-hdfs/src/main/java/org/apache/streams/hdfs/WebHdfsPersistReader.java ---
@@ -204,6 +212,83 @@ public StreamsResultSet readCurrent() {
return current;
}
+ public StreamsDatum processLine(String line) {
+
+ String[] fields = line.split(hdfsConfiguration.getFieldDelimiter());
+
+ if( fields.length == 0)
+ return null;
+
+ String id = null;
+ DateTime ts = null;
+ Map<String, Object> metadata = null;
+ String json = null;
+
+ if( hdfsConfiguration.getFields().contains( HdfsConstants.DOC )
--- End diff --
this would be a lot more readable if you pulled out `hdfsConfiguration.getFields()` into its own variable
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: resolves STREAMS-342
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-streams/pull/234
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: resolves STREAMS-342
Posted by eponvert <gi...@git.apache.org>.
Github user eponvert commented on the pull request:
https://github.com/apache/incubator-streams/pull/234#issuecomment-114155364
:+1: looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---